Problem/Motivation

\Drupal\KernelTests\Config\DefaultConfigTest installs node when testing rest and hal because before #2308745: Remove rest.settings.yml, use rest_resource config entities there was an implicit dependency on node.

Proposed resolution

#2308745: Remove rest.settings.yml, use rest_resource config entities is in core. There is no implicit dependency therefore we don't need to install node. As a test-only change this should be backported to 8.5.x to keep the tests in both branches as similar as possible. The fix that makes this no longer necessary was committed in 8.2.0.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2938834-2.patch1002 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Active » Needs review
FileSize
2938834-2.patch1002 bytes
navneet0693’s picture

navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commented
Status: Needs review » Reviewed & tested by the community

Straight forward. :-)

  • larowlan committed a201fd2 on 8.6.x 
    Issue #2938834 by alexpott: Resolve out-dated @todo in DefaultConfigTest

  • larowlan committed 8ad40fc on 8.5.x 
    Issue #2938834 by alexpott: Resolve out-dated @todo in DefaultConfigTest...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed as a201fd2 and pushed to 8.6.x

Cherry picked as 8ad40fc and pushed to 8.5.x

Thanks.

Pretty sure I've got some contrib projects in the same boat.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.