Problem

Composite element and multiple elements should fully support client-side and server-side conditional logic.

Solution

Improve Composite element and multiple element #states API support.

Tasks

  • Setup test forms form composite and multiple elements.
  • webform.webform.test_form_states_server_multiple.yml
  • webform.webform.test_form_states_server_composite.yml
  • Audit conditional behavior and better document concepts.
  • Don't visually require the more items input element.
  • Fix single composite element
  • Fix multiple single element
  • Fix multiple composite without required sub-elements
  • Fix multiple composite with required sub-elements
  • Check custom composite elements
  • Write tests

Notes

  • We might need to track and cache an element's #states API.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

  • jrockowitz committed 704757a on 2938651-improve-state-api-support
    Issue #2938651: Improve Composite element and multiple element #states...

  • jrockowitz committed 286e373 on 2938651-improve-state-api-support
    Issue #2938651: Improve Composite element and multiple element #states...
jrockowitz’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
0 bytes

The attached patch is not ready for any review. I just need to make sure I am not breaking any tests while refactoring some code.

Status: Needs review » Needs work

The last submitted patch, 4: 2938651-4.patch, failed testing. View results

jrockowitz’s picture

Status: Needs work » Needs review
FileSize
24.27 KB

Status: Needs review » Needs work

The last submitted patch, 6: 2938651-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • jrockowitz committed 82b4074 on 2938651-improve-state-api-support
    Issue #2938651: Improve Composite element and multiple element #states...

  • jrockowitz committed 6e904e2 on 2938651-improve-state-api-support
    Issue #2938651: Improve Composite element and multiple element #states...
jrockowitz’s picture

Status: Needs work » Needs review
FileSize
32.81 KB

The attached patch is not ready for any review. It needs to test coverage.

  • jrockowitz committed c46948c on 2938651-improve-state-api-support
    Issue #2938651: Improve Composite element and multiple element #states...

  • jrockowitz committed bbbd936 on 2938651-improve-state-api-support
    Issue #2938651 by jrockowitz: Improve Composite element and multiple...
jrockowitz’s picture

jrockowitz’s picture

This is done and ready for review. I will probably commit it tomorrow.

  • jrockowitz committed b762eda on 2938651-improve-state-api-support
    Issue #2938651 by jrockowitz: Improve Composite element and multiple...
jrockowitz’s picture

jrockowitz’s picture

Status: Needs review » Reviewed & tested by the community

  • jrockowitz committed 27d69eb on 8.x-5.x
    Issue #2938651 by jrockowitz: Improve Composite element and multiple...
jrockowitz’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.