I did some performance tests with subrequest module and figured that page cache was not working.

Problem was a notice due to the unset 'body' attribute for my blueprint request, which was a GET request. Result was a drupal message as error reporting is on in my dev setup, thus page cache was disabled.

Attached patch fixes the notices and thus page cache. It might be a good idea to improve test coverage for some various blueprint requests and page cache but that would be best done in a separate issue imo.

CommentFileSizeAuthor
#2 d8_subrequests_notices.patch1017 bytesfago

Issue fork subrequests-2938625

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
Status: Active » Needs review
FileSize
d8_subrequests_notices.patch1017 bytes
fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
Title: Notices of GET blueprint requests and broken page cache » Notices of GET blueprint requests cause a broken page cache
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

Thanks for the patch!

  • e0ipso committed 5aea206 on 8.x-2.x authored by fago 
    Issue #2938625 by fago: Notices of GET blueprint requests cause a broken...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hhvardan made their first commit to this issue’s fork.