Problem/Motivation

In #2289917: Convert "messages" page element into blocks the 'display' variable was refactored away from '#theme' => 'status_messages' to '#type' => 'status_messages'. As a result, the 'display' variable is no longer available in status-messages.html.twig. However ,this variable was not removed from the status-messages.html.twig docblock.

Proposed resolution

Remove documentation for the 'display' variable from status-messages.html.twig

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#7 interdiff-2936161-2-7.txt823 bytesyogeshmpawar
#7 2936161-7.patch3.39 KByogeshmpawar
#2 drupal-remove_reference_to_display-2936161-2.patch2.58 KBidebr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Active » Needs review
FileSize
drupal-remove_reference_to_display-2936161-2.patch2.58 KB

Attached patch removes all references to the 'display' variable in the status-messages.html.twig templates in the system module and the core themes Stable, Bartik, Classy

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sk33lz’s picture

sk33lz CreditAttribution: sk33lz at Zivtech commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Nashville2018

Patch #2 applies cleanly to 8.6.x and removes the display variable as intended. Moving status to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Needs work

We have a new theme now. Need to do core/profiles/demo_umami/themes/umami/templates/components/messages/status-messages.html.twig too.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: Unassigned » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
FileSize
2936161-7.patch3.39 KB
interdiff-2936161-2-7.txt823 bytes

Updated patch as per comment #5 & interdiff added too.

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Needs review » Reviewed & tested by the community

@Yogesh Pawar Thanks for picking this up!

The documentation is correctly updated for the new umami theme. No new themes have been added in the meantime, so setting back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Crediting myself for #5.

Committed and pushed d01bb4f633 to 8.6.x and 0f7d3d5397 to 8.5.x. Thanks!

Backported to 8.5.x since this is a docs patch.

  • alexpott committed d01bb4f on 8.6.x 
    Issue #2936161 by Yogesh Pawar, idebr, alexpott: status-messages.html....

  • alexpott committed 0f7d3d5 on 8.5.x 
    Issue #2936161 by Yogesh Pawar, idebr, alexpott: status-messages.html....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.