Problem/Motivation

Noticed that 2 migrate tests are not in the group 'migrate', one is in 'migration' and the other is 'Migration'. Lets get them into the correct group.

The files are:

core/modules/migrate/tests/src/Unit/Exception/RequirementsExceptionTest.php: * @group migration
core/modules/migrate/tests/src/Unit/MigrationTest.php: * @group Migration

This is simple editing, tagging as novice.

Proposed resolution

Change the test group in the two files to 'migrate.

Remaining tasks

Write a patch
review
commit
Smile!

User interface changes

These tests will appear in the 'migrate' list at admin/config/development/testing

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

sonu.raj.chauhan’s picture

Assigned: Unassigned » sonu.raj.chauhan
sonu.raj.chauhan’s picture

Status: Active » Needs review
FileSize
1007 bytes

All the mentioned changes have been done.
Please review.

quietone’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Migrate January 2018 Sprint

Applied the patch and confirmed that the tests appear in the 'migrate' group in the UI and from the CLI.

@sonu.raj.chauhan, thank you. Great work!

snehi’s picture

+1

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Great find, thanks!

  • Gábor Hojtsy committed c944475 on 8.5.x
    Issue #2935822 by sonu.raj.chauhan, quietone: Correct test group for two...
priya.chat’s picture

Assigned: sonu.raj.chauhan » Unassigned
Status: Fixed » Active
Issue tags: -Migrate January 2018 Sprint
FileSize
1007 bytes

Hi, I have made changes as you mentioned and adding a patch for the solution. Please review this.

priya.chat’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: correct-test-group-2935822-2.patch, failed testing. View results

quietone’s picture

Status: Needs work » Fixed

@priya.chat, thank you for joining the Migrate January 2018 Sprint! The patch looks great but this is was resolved and committed in #7. You are welcome to join us in IRC, #drupal-migrate, we can help you find an issue to work on. Cheers

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.