Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Steps to create:
1. Download the module
2. Create a web form.
3. Under wizard settings, by default it looks empty.
Proposed solution
--None-- or --Select-- can be added in the drop-down.
Note: Most of the dropdowns have empty space and it does not look good. Sorry for being pedantic about the UI-text :)
Comment | File | Size | Author |
---|---|---|---|
#15 | 2934087-15.patch | 22.68 KB | jrockowitz |
| |||
#13 | 2934087-13.patch | 18.42 KB | jrockowitz |
#11 | 2934087-11.patch | 21.89 KB | jrockowitz |
#9 | 2934087-9.patch | 22.68 KB | jrockowitz |
#7 | 2934087-7.patch | 18.56 KB | jrockowitz |
Comments
Comment #2
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedI am not sure I want to change this.
The tricky part is that most users should not be setting these select menu values and '- None -' or '- Select -' might entice them to set a value.
We could use - Default (value) -.
Comment #3
Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at Drupal Partners for Innoppl Technologies Pvt. Ltd commentedSo instead of
We can go for
Or
If you are suggesting to leave a default value, it's fine, but leaving an empty box for empty value does not look good when a normal user/client is trying to create a web form. Besides the field is not required. So I think we can give an empty option for site builders or clients.
Thanks :)
Comment #4
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedI think we would have to go with just
To make this change we would need to look at all the
'#type' => 'select'
element'#empty_options' => '',
... and #options for...
'' => ''
Comment #5
Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at Drupal Partners for Innoppl Technologies Pvt. Ltd commentedI'll look into this
Comment #6
Maheshwaran.j CreditAttribution: Maheshwaran.j as a volunteer and at Drupal Partners for Innoppl Technologies Pvt. Ltd commentedI have created a patch for this. Please review this.
Comment #7
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedI did a full review of all the select menus as established the below convention.
Required: - Select -
Optional: - None -
Default: - Default -
I also converted < Default > to - Default -
Comment #9
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #11
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedI am stumped because the failing test is passing locally.
The attached patch is just a guess.
Comment #13
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedI reverting all changes to \Drupal\webform\Form\AdminConfig\WebformAdminConfigElementsForm in the hope that the tests pass so that I can commit this patch. Then we can update WebformAdminConfigElementsForm.
Comment #15
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #18
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedI committed the patch. Please download the latest dev release to review.
This was the regression #2934542: Fix broken Webform.Drupal\webform\Tests\WebformLibrariesTest that was causing the failing tests.