In #2850777: Why are webform modules features?, the various webform modules had their *.features.yml removed, with a solution being Jake could .gitignore them locally to take advantage of Features.

However, the test modules are all Features. In a couple cases, they export config that is really common (e.g. the translation and Lingotek translation modules export French, Spanish, and Russian language entities). Even though these modules are not installed, the config is still owned by them, and that config overrides Features we create that attempts to have that config defined.

I personally find it weird that an uninstalled module could have its config installed by Features, but regardless, it would be helpful if Webform could the same local .gitignore strategy to its tests that it does to its non-test modules.

Comments

timcosgrove created an issue. See original summary.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented

Test modules are features to make maintaining these modules and config files a little easier.

Are you installing the test modules for any specific purpose other than testing?

timcosgrove’s picture

timcosgrove CreditAttribution: timcosgrove at Pinterest commented

I am not installing the modules. However, the config for language.entity.es.yml is still owned by Webform Test Translation Lingotek and language.entity.fr.yml by Webform Test Translation, respectively.

I'm spinning up an otherwise vanilla SimplyTest.Me image w/ webform and Features to doublecheck this.

timcosgrove’s picture

timcosgrove CreditAttribution: timcosgrove at Pinterest commented

Actually, unable to do this via SimplyTest.me, which does not install test modules.

Is there a reason to commit the *.features.yml to the repository? I thought per #2850777: Why are webform modules features? you were able to keep locally them for your own purposes in the non-test modules but exclude them from what was committed.

  • jrockowitz committed 3330bbb on 8.x-5.x 
    Issue #2932211: Webform test modules should not be features.

  • jrockowitz committed 8005c80 on 8.x-5.x 
    Issue #2932211: Webform test modules should not be features.
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Active » Fixed

Done! I just made the changes directly to the 8.x-5.x. branch.

timcosgrove’s picture

timcosgrove CreditAttribution: timcosgrove at Pinterest commented

You are a madman. Thank you!

I am very curious why uninstalled Features modules can own config, but I suspect that's a rabbit hole and not easily solved.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.