Consider to release 8.x-2.x and update league/csv to 9.x [#2931148]

Problem/Motivation

The library used stopping to support for 8.x version after 2018-02-18 and moving to 9.x that require PHP 7
https://csv.thephpleague.com/

Proposed resolution

- Update library to 9 version & fix code for new version this information
- Create new 8.x-2.x branch
- Update project page about requirement of PHP7 for 2.x version

Comment	File	Size	Author
#5	interdiff_2-5.txt	2.66 KB	tarasich
#5	csv_serialization-2931148-5.patch	6.57 KB	tarasich
#5
#2	csv_serialization-2931148-2.patch	6.87 KB	r.nabiullin
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

15 December 2017 at 21:14

nabiyllin created an issue. See original summary.

Comment #2

r.nabiullin CreditAttribution: r.nabiullin as a volunteer and at Skilld commented 15 December 2017 at 21:16

Status:

Active

» Needs review

File	Size
csv_serialization-2931148-2.patch	6.87 KB

Also was cleaned code.

Comment #3

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 16 December 2017 at 06:39

+++ b/src/Encoder/CsvEncoder.php
@@ -66,6 +68,13 @@ class CsvEncoder implements EncoderInterface, DecoderInterface {
+  protected $encoding = 'utf-8';

this looks unused

+++ b/src/Encoder/CsvEncoder.php
@@ -339,15 +354,19 @@ class CsvEncoder implements EncoderInterface, DecoderInterface {
+   * @param array $settings
+   *   Array of settings.

Please add @see to point where settings listed

+++ b/src/Encoder/CsvEncoder.php
@@ -339,15 +354,19 @@ class CsvEncoder implements EncoderInterface, DecoderInterface {
-    $this->useUtf8Bom = ($settings['encoding'] === 'utf8' && !empty($settings['utf8_bom']));
+    $this->useUtf8Bom = ($settings['encoding'] === 'utf-8' && !empty($settings['utf8_bom']));

the change of setting value may break BC, not sure it makes sense to add `-`

Comment #4

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 21 March 2018 at 11:50

Title:	Update library and fix integration with views_data_export for using different encoding	» Consider to release 8.x-2.x and update league/csv to 9.x
Issue summary:	View changes
Issue tags:	-views_data_export views, -views_data_export, -league, -CSV	+PHP 7.0 (duplicate)