Error when update [#2930116]

Comment	File	Size	Author
#8	2930116-8.patch	2.19 KB	jrockowitz
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.4 676 pass
#8	Update Drupal 8 Demo Site.png	79.08 KB	jrockowitz
#5	Screen Shot 2017-12-13 at 1.07.06 PM.png	72.66 KB	jrockowitz

Comment #1

12 December 2017 at 08:47

selinav created an issue. See original summary.

Log in or register to post comments

Comment #2

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 12 December 2017 at 10:47

Did you update the Webform module via the UI?

Can you try updating the Webform module via FTP or Drush?

@see #2924044: Error when update

Log in or register to post comments

Comment #3

selinav CreditAttribution: selinav commented 12 December 2017 at 11:13

I update via tue UI on local.

Log in or register to post comments

Comment #4

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 December 2017 at 17:49

@see #2352637: Remove the UI for installing/updating modules from update module if it is not fixed in time for release

Log in or register to post comments

Comment #5

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 December 2017 at 18:09

File	Size
Screen Shot 2017-12-13 at 1.07.06 PM.png	72.66 KB

I could not update the webform module via the UI using simplytest.me.

I am not about to try and fix the update manager but I will add a warning to the page.

Log in or register to post comments

Comment #6

selinav CreditAttribution: selinav commented 13 December 2017 at 18:33

If I well understand, I should transfer files with FTP and run update.php ?

Log in or register to post comments

Comment #7

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 December 2017 at 18:50

Yes!

Log in or register to post comments

Comment #8

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 December 2017 at 19:24

Status:

Active

» Needs review

File	Size
Update Drupal 8 Demo Site.png	79.08 KB
2930116-8.patch	2.19 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.4 676 pass

The attached patch adds the below warnings to the 'Update manager'.

If someone investigates and fixes the problem, we should remove these warnings.

Log in or register to post comments

Comment #9

13 December 2017 at 19:47

jrockowitz committed 2da32cc on 8.x-5.x

Issue #2930116 by jrockowitz: Error when update

Log in or register to post comments

Comment #10

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 December 2017 at 19:48

Status:

Needs review

» Fixed

Log in or register to post comments

Comment #11

selinav CreditAttribution: selinav commented 18 December 2017 at 14:00

Hello,

I've tested on local to download manually files but I get an error message.

TypeError: Argument 3 passed to Drupal\webform\EventSubscriber\WebformSubscriber::__construct() must implement interface Drupal\Core\Render\RendererInterface, none given, called in C:\wamp64\www\fta\core\lib\Drupal\Component\DependencyInjection\Container.php on line 266 in Drupal\webform\EventSubscriber\WebformSubscriber->__construct() (line 69 of modules\webform\src\EventSubscriber\WebformSubscriber.php).

I've tested with to update from beta24 to beta 25 with composer and I get this message :

composer update drupal/webform
Package "drupal/webform" listed for update is not installed. Ignoring.
...

It is strange.
I've search on my module directory and I find 2 webform directories.
One in /modules/webform
An other in /modules/contrib/webform

It is may be due to this.

If I uninstall the webform module, will I lose my already set forms?

Log in or register to post comments

Comment #12

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 18 December 2017 at 14:06

Yes, the two directories are most likely causing the issue. You need to delete the older one. You should look at the version number in webform.info.yml.

Log in or register to post comments

Comment #13

selinav CreditAttribution: selinav commented 18 December 2017 at 14:15

If I delete the directory in contrib modules it continues to well works.
If I delete the directory in /modules/webform it break the website.

The good directory is so /modules/webform

But :
- I can't update with composer who search in contrib directory and find nothing.

composer update drupal/webform
Package "drupal/webform" listed for update is not installed. Ignoring.
...

If I replace the /modules/webform with the beta 25 version I get and error message.

The website encountered an unexpected error. Please try again later.
TypeError: Argument 3 passed to Drupal\webform\EventSubscriber\WebformSubscriber::__construct() must implement interface Drupal\Core\Render\RendererInterface, none given, called in C:\wamp64\www\fta\core\lib\Drupal\Component\DependencyInjection\Container.php on line 266 in Drupal\webform\EventSubscriber\WebformSubscriber->__construct() (line 69 of modules\webform\src\EventSubscriber\WebformSubscriber.php).

I don't know how to resolve this problem.

what should I do ?