Can't use "Show weight values" link with a draggable view

This is sort of fixed in 1.x-dev, it no longer skips a blank column, but it also doesn't show the weight input fields.

This issue is not broken anymore. However I do feel it is not really nice since the table drag is using match instead of order so it has a nice fallback for non javascript use, or even being able to edit the order when you have a very large list of items.

@gordon Do you mean that you are seeing the row weight fields and those fields work correctly when you click the "Show row weights"? I do not see the fields when I click the link. All I see is that the draggable icons disappear.

Without the row weight fields working correctly, this is an accessibility problem.

Yes so when you click show row weight to turn off the drag and drop you should really see the actual weight fields, but you do not.

I have noticed this. It is a bug or a bug of a bigger problem.

I'd flag this as mayor as it is a mayor accessibility issue.

I have created a patch which includes the following:

1. Adds a weight textfield which is displayed when "Show row weights" is clicked.
2. Modifies the submit by using the value of the weight textfield from the draggableviews item as the weight
3. Adds JS functionality to update the weight textfield value when dragging

Re-rolled #9 against latest dev.

My logs started filling up with Notice: Undefined property: Drupal\views\ResultRow::$draggableviews_structure_weight in Drupal\draggableviews\Plugin\views\field\DraggableViewsField->viewsForm() (line 142... after applying the patch in 11

Tested the patch from #9 and it works, however it springs an error. I've created a patch on top of this which seems to fix the error. The code was assuming 'group' was set as it was only checking for 'table'. I've added 'group' to the check and the code seems to work now.

Notice: Undefined index: group in draggableviews_views_data_alter() (line 45 of /docroot/modules/contrib/draggableviews/draggableviews.module)

Found an issue with the patch i created. When changing the weight of the items in the list it would duplicate them. Adding separate checks for 'group' and 'table' fixed this.

Re-rolled #9 with the latest version and with the added isset check for the 'group' from #14

Patch #15 works for me if I add "Draggableviews: DraggableViews Weight" into fields in the view. Otherwise it shows a lot of Notice: Undefined property: Drupal\views\ResultRow::$draggableviews_structure_weight in Drupal\draggableviews\Plugin\views\field\DraggableViewsField->viewsForm() (line 124 of /var/www/html/rogertechnology.localhost/modules/contrib/draggableviews/src/Plugin/views/field/DraggableViewsField.php) error messages.

Fixing tagging.

The last patch in #15 failed to apply to the latest dev version.

Rerolled the patch in #15 against the latest dev version.

Updated the last patch file.

FYI, there are no automated tests available for 8.x-1.x-dev. See: https://www.drupal.org/node/283087/qa

Committed. Tested added

Not sure it's OK to post on a closed item. I have the same problem as is reported (can't get a weight field to show up when I click "Show row weights" in a draggable view in D8). The comments make it sound like it's been fixed. I've made sure I have the latest build, but I still get nothing. Wondering if there's a secret to the setup I'm missing.

@morrisem this was committed after 1.2 was release. It's working for me with the latest dev snapshot. The textboxes are added on the far right instead of in place of the drag handles so it's not super obvious but they are there.