Using 8.x-1.21 on Drupal 8.4.0, I enabled only the admin_toolbar_links_access_filter module, but nothing happened. However, if I also enable admin_toolbar then it works as expected.

admin_toolbar_links_access_filter has no dependency on admin_toolbar in it's .info.yml and looking at the code, it really shouldn't need admin_toolbar. It'd be nice to be able to use it without the dropdowns, but if it is really necessary to have admin_toolbar enabled, it'd be good to put an explicit dependency in the .info.yml file.

CommentFileSizeAuthor
#6 admin_toolbar-add_dependency-2929061-6-d8.patch844 bytesromainj
#2 admin_toolbar-add_dependency-2929061-2-d8.patch830 bytesromainj
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

romainj’s picture

romainj CreditAttribution: romainj as a volunteer commented
FileSize
admin_toolbar-add_dependency-2929061-2-d8.patch830 bytes

This module should have a dependency to the Admin Toolbar module.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

Hi @dsnopek thanks for reporting, can you use the next time the Issue Summary Template?

When we made the inclusion of Administration links access filter in Admin Toolbar #2917704: Add Administration links access filter module as Admin Toolbar submodule the dependency was not added because in the Administration links access filter says:

Although not strictly necessary, the usage of the Admin Toolbar is strongly recommended.

And I'm really don't made the test to check if this was true :-( But fortunately now this will be solved :-)

@Romainj, now we need to add the dependency as:

dependencies:
  - admin_toolbar:admin_toolbar

Check #2927905: All dependencies must be prefixed with the project name

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Status: Active » Fixed
romainj’s picture

romainj CreditAttribution: romainj as a volunteer commented
FileSize
admin_toolbar-add_dependency-2929061-6-d8.patch844 bytes

@adriancid I always forget about this :)

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

@romainj, no problem, I just noticed this a few days ago, when I updated the phpcs rulesets and run it against the project :-)

Salut! ;-)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Woohoo! Thanks for the quick resolution :-)

@dsnopek thanks for reporting, can you use the next time the Issue Summary Template?

For sure!

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

Woohoo! Thanks for the quick resolution :-)

:-D

  • romainj committed cb0fb1f on 8.x-1.x 
    Issue #2929061 by romainj, adriancid, dsnopek:...
romainj’s picture

romainj CreditAttribution: romainj as a volunteer commented

Committed in latest dev version. Thanks.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

@romainj we made the commit twice :-D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.