Theme hook link not found.

Hello,
Please review my patch, I am not sure about it, because I can't reproduce the warning in DB log.
Thanks.

Hello. Thanks for the patch.

The styleguide_links is Styleguide theme hook. It used to display the page elements navigation menu, so we shouldn't remove it.

The issue comes from Generator (http://cgit.drupalcode.org/styleguide/tree/src/Generator.php?h=8.x-1.x#n168) where used this missed theme hook link. So the link generation in sentence method needs to be fixed to build it correctly.

Your patch fixed the warning messages, but the links are still not displaying on the StyleGuide page.

I think it's because of '#url' => $link, , the #url option requires Drupal\Url object (core/lib/Drupal/Core/Render/Element/Link.php)

Thanks for the patch.

+++ b/src/Generator.php
@@ -154,6 +154,8 @@ class Generator implements GeneratorInterface {
+
+

Please remove these extra empty lines

+++ b/src/Generator.php
@@ -163,16 +165,20 @@ class Generator implements GeneratorInterface {
+      if (filter_var($link, FILTER_VALIDATE_URL)) {
+        $explode = explode(' ', $sentence);
+        $link = [
+          '#type' => 'link',
+          '#title' => $explode[0],
+          '#url' => \Drupal\Core\Url::fromUri($link),

We should allow adding any kind of URL in the sentence. Looks like will be better to move \Drupal\Core\Url::fromUri($link) outside the sentence() method.

+++ b/src/Plugin/Styleguide/defaultStyleguide.php
@@ -529,7 +529,7 @@ class DefaultStyleguide extends StyleguidePluginBase {
-      drupal_set_message($this->generator->sentence('http://www.example.com'), $message);
+      drupal_set_message(t($this->generator->sentence('http://www.example.com')), $message);

I mean we should create and pass this \Drupal\Core\Url object here, this way a user can create the Url object using any available method and pass it into $this->generator->sentence() method. Also, this link path shouldn't be translatable.

Behaviour stays the same as before.
Just instead of using the 'http://www.example.com' (string) in $this->generator->sentence('http://www.example.com') need to pass object (\Drupal\Core\Url) as argument.

The goal was to keep '#path' => $link, , just make the $link of \Drupal\Core\Url type, as the '#type' => 'link', requires for the '#path' \Drupal\Core\Url value.
No need to use the t() function here, we generate new sentence every time.

+++ b/src/Generator.php
@@ -165,18 +166,19 @@ class Generator implements GeneratorInterface {
         '#options' => array(
           'attributes' => array(),
           'html' => FALSE,
-        ),
+          ),

Please remove 2 extra spaces. All other code looks good now :)

Thank you! The patch was committed.