In /core/modules/comment/src/Plugin/views/sort/Thread.php we have:

    // Read comment_render() in comment.module for an explanation of the
    // thinking behind this sort.
     if ($this->options['order'] == 'DESC') {
       $this->query->addOrderBy($this->tableAlias, $this->realField, $this->options['order']);
     }

Which is obviously obsolete. This should point readers to \Drupal\comment\CommentStorage::loadThread() instead.

CommentFileSizeAuthor
#2 2927520-2.patch764 bytesmarcoscano
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

marcoscano created an issue. See original summary.

marcoscano’s picture

Assigned: marcoscano » Unassigned
Status: Active » Needs review
FileSize
764 bytes
borisson_’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for opening this in a new issue! Looks great.

  • xjm committed 42634ef on 8.5.x
    Issue #2927520 by marcoscano: Fix wrong documentation in comment module
    

  • xjm committed d70c7db on 8.4.x
    Issue #2927520 by marcoscano: Fix wrong documentation in comment module...
xjm’s picture

Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

I confirmed this is the only remaining reference to comment_render in the codebase. Committed and pushed to 8.5.x and cherry-picked to 8.4.x as a docs improvement. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.