Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #2909370: Fix 'Drupal.Commenting.VariableComment.IncorrectVarType' coding standard
Remove full stops (semicolons, periods) from @var tags.
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff-7-13.txt | 522 bytes | zaporylie |
#13 | 2926120-13.patch | 35 KB | zaporylie |
#7 | 2926120-7.patch | 35.05 KB | idebr |
#7 | interdiff-5-7.txt | 3.12 KB | idebr |
Comments
Comment #2
zaporylieComment #3
borisson_Tested this with ag
ag "@var (.*)\."
Not sure if we should fix those @var declarations that have a php file as well in this issue, but the other ones should still be fixed.
This patch is also fixing semicolons, those are all ok.
Comment #5
idebr CreditAttribution: idebr at ezCompany commented#3 Fixed the occurrences mentioned in the comment, but I was unable to install
ag
on my Windows machine to check for new violations. Can you take a look?Comment #6
idebr CreditAttribution: idebr at ezCompany commentedFound a few more:
Comment #7
idebr CreditAttribution: idebr at ezCompany commentedFixed the violations mentioned in #6
Comment #8
borisson_I tried to run composer phpcs after applying this patch and couldn't find any remaining issues.
Comment #9
catchThe patch looks fine except shouldn't it also enable the rule?
Comment #10
zaporylieNo. It is just split of #2909370: Fix 'Drupal.Commenting.VariableComment.IncorrectVarType' coding standard on request from xjm.
Comment #11
zaporylieComment #12
larowlanShouldn't this just be 'int'?
Comment #13
zaporylieFrom MigrationInterface.php:
Therefore, I think #12 is a good idea. Moving back to RTBC.
Comment #14
larowlanAdding review credit for @borisson_ who did manual ag work to verify
Comment #15
larowlanCommitted as 0d6d22a and pushed to 8.6.x.