Menu does not take changes into account (caching issue)

Hi @eme, this is related to #2899392: user_hook_toolbar() makes all pages uncacheable

The caching issue does not affect only items from Admin Toolbar Extra Tools, it applies to manually adding and deleting menu items from the Administration menu as well.
After deleting a menu item when the admin_toolbar module is enabled, the whole site breaks with the error Query condition 'menu_link_content.uuid IN ()' cannot be empty until cache is cleared manually.

P.S. It seems that the issue does not occur if I disable the menu items - they get removed from the admin toolbar menu immediately. Deleting disabled menu items does not cause an error.

@eme I think that if we revert the lazzy builder we will fix a lots of problems. And we can included when is really working fine. Is weird that I can't reproduce many issues that have been created after the 1.21 release. This is the only that I can confirm exists related to the "random" toolbar problems.

@eme it seems that we have many problems with the lazzy builder (and this is the only that I can reproduce, so is difficult to find the solution for something that always works in your environment) I think that is better to revert for the moment the lazzy builder and wait to see if @finne or another user can find the final solution, I don't know what do you think about this?

For the moment I will revert and commit to dev to see if the problem is solved for the other issues, I'll notice in the other issue to see the users feedback.

eme and adriancid

Tested admin_toolbar-dev-8.x-1.22 - With the admin menu is put to the side it keeps its drop down facilities.

Thanks for your work, its a great module.

Thanks @AlexJ, and the others issues that you reported are solved too?

@adriancid. Running - Machine name: admin_toolbar - Version: 8.x-1.21+8-dev - and its all good, when I maximise ckeditor, no obscuring occurs. Thanks..

For the moment this solve:

#2926446: Menu on side loses dropdown
#2925742: Update leads to WSOD

This is solved too:

#2926101: Error after updating to 8.x-1.21

Thanks for this fix! We've tried the latest dev and it works well. I'm pleased that I can use the sidebar menu again!

The user TamCalderwood was actually the one who did the testing for us at Microserve - I mention so she gets the credit she deserves :)

Thanks @Sophie.SK adding credit, I think that we will release a new version this week, we are waiting for the review of:

#2926844: admin_toolbar_tools is not creating links on Appearance, Extend and People when installed.
#2929053: admin_toolbar.js should use Drupal behaviors

If somebody can help us this will be great!

The commit made here solve too this issue:

#2925145: Notice: Undefined index: url

This issue solve too #2923466: Inconsistent dropdown behaviour with admin menu

I'm seeing this issue again myself. Could it be a Drupal 8.5 issue?

I experience the same issue again with latest 1.25 version.
If admin_toolbar is uninstalled links are working flawlessly. I haven't looked deeper yet but it seems like $menu_tree which is loaded from the service container contains links which are no longer existing. Anyone else with the same problem?