When the module generates a new sitemap.xml file and notifies the search engines (Google and Bing), it uses the HTTP protocol.

Both Google and Bing use HTTPS for all their services, so they respond with an 301 HTTP responde status code, which makes the module send the notification again to the new URL.

The module should use HTTPS protocol both for Google and Bing.

This issue is related to the issue #2907878: Use HTTPS protocol when notifying search engines, but in this case it's over the 8.x-1.x version.

CommentFileSizeAuthor
#3 xmlsitemap-use_https_for_search_engines-2923583-3.patch1.1 KBtucho
#2 xmlsitemap-use_https_for_search_engines-2907878-3.patch1.1 KBtucho
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tucho created an issue. See original summary.

tucho’s picture

tucho
Primary language Spanish
Location Buenos Aires
CreditAttribution: tucho at gcoop Cooperativa de Software Libre commented
Status: Active » Needs review
FileSize
xmlsitemap-use_https_for_search_engines-2907878-3.patch1.1 KB

I have uploaded a patch that updates the search engines notification URL addresses for both Google and Bing for the 8.x-1.x version.

tucho’s picture

tucho
Primary language Spanish
Location Buenos Aires
CreditAttribution: tucho at gcoop Cooperativa de Software Libre commented
FileSize
xmlsitemap-use_https_for_search_engines-2923583-3.patch1.1 KB

Sorry!
I updated the patch of the related issue without renaming it to respect the patch name convention.

Uploaded again with the correct name!

GeduR’s picture

GeduR CreditAttribution: GeduR at Metadrop commented
Status: Needs review » Reviewed & tested by the community

It looks nice to me, as it uses the same approach as the D7 version (already committed). Moving to RTBC

devad’s picture

devad CreditAttribution: devad as a volunteer commented
Issue summary: View changes
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Reviewed & tested by the community » Needs work

the patch did not pass automatic tests

tucho’s picture

tucho
Primary language Spanish
Location Buenos Aires
CreditAttribution: tucho at gcoop Cooperativa de Software Libre commented
Status: Needs work » Needs review

Hi @pifagor!

It seems that the tests failures [0] has nothing to do with this patch.

The patch still applies on the current dev, so I change the status to Needs review again.

[0] https://www.drupal.org/pift-ci-job/917841

tucho’s picture

tucho
Primary language Spanish
Location Buenos Aires
CreditAttribution: tucho at gcoop Cooperativa de Software Libre commented
Status: Needs review » Reviewed & tested by the community

The patch still applies, so I have retested the patch on the current versions of Drupal Core and all the tests finished ok.

I set again the RTBC promoted by @GeduR.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented

  • pifagor committed 0429cb8 on 8.x-1.x authored by tucho 
    Issue #2923583 by tucho, pifagor, GeduR, devad: Use HTTPS protocol when...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.