CommentFileSizeAuthor
#8 list_gigya_credential_settings-2922989-8.patch386 bytesgg24
#7 list_gigya_credential_settings-2922989-7.patch795 bytesgg24
#6 After_gigya_menu.png50.22 KBguptahemant
#6 before_gigya_menu.png39.21 KBguptahemant
#5 After_gishya_menu.png50.22 KBguptahemant
#5 before_gishya_menu.png39.21 KBguptahemant
#4 list_gigya_credential_settings-2922989-2.patch394 bytesgg24
#3 list_gigya_credential_settings-2922989.patch397 bytesgg24

Comments

gg24 created an issue. See original summary.

gg24’s picture

gg24 commented
Title: List the Gigya Cofiguration page under Configuration Menu. » List the Gigya credentials settings under Configuration Menu.
gg24’s picture

gg24 commented
Assigned: gg24 » Unassigned
Status: Active » Needs review
StatusFileSize
new list_gigya_credential_settings-2922989.patch397 bytes

Attaching a patch to list Gigya credential settings under configuration menu.
Please review.

Thanks!

gg24’s picture

gg24 commented
StatusFileSize
new list_gigya_credential_settings-2922989-2.patch394 bytes
guptahemant’s picture

guptahemant commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_gishya_menu.png39.21 KB
new After_gishya_menu.png50.22 KB

hi @gg24
I have reviewed your patch it applies cleanly and here are the attached screenshot of before and after.It works correctly hence marking the issue as RTBC.

guptahemant’s picture

guptahemant commented
StatusFileSize
new before_gigya_menu.png39.21 KB
new After_gigya_menu.png50.22 KB
gg24’s picture

gg24 commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new list_gigya_credential_settings-2922989-7.patch795 bytes

Adding correct configure link in gigya.info.yml.

Thanks!

gg24’s picture

gg24 commented
StatusFileSize
new list_gigya_credential_settings-2922989-8.patch386 bytes

Please review the new patch, following standard by making route and configure link same.

Thanks!

guptahemant’s picture

guptahemant commented
Status: Needs review » Reviewed & tested by the community

hi @gg24,
I have reviewed your in #8 and it is working correctly ,hence marking this issue as RTBC.

Thanks