I was leveraging Entity Traits and used the new BundleFieldDefinition class in Entity API; however, Commerce explicitly was pointing to its (effectively deprecated, identical child class) own implementation in the trait manager, which threw a PHP type mismatch error. This PR deprecates the class per the Drupal coding standard, updates the various references in Commerce core, and thus allows/encourages third parties to use the class from Entity module.

Comments

bradjones1 created an issue. See original summary.

bradjones1’s picture

bojanz’s picture

Good idea!

bradjones1’s picture

This was expanded to also include BundlePluginInterface.

bojanz’s picture

Title: Deprecate Commerce's BundleFieldDefinition » Deprecate BundleFieldDefinition and BundlePluginInterface
Category: Bug report » Task

  • bojanz committed 654bf3d on 8.x-2.x authored by bradjones1
    Issue #2922811 by bradjones1, bojanz: Deprecate BundleFieldDefinition...
bojanz’s picture

Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.