Problem/Motivation

As per https://groups.drupal.org/node/517837, Dries has appointed plach as our newest provisional framework manager.

Proposed resolution

Update MAINTAINERS.txt.

Remaining tasks

NR.
Dries has already signed off by posting https://groups.drupal.org/node/517837. :)
xjm granted plach "Write to VCS" permission on https://www.drupal.org/node/3060/maintainers.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

xjm created an issue. See original summary.

xjm’s picture

FileSize
479 bytes
xjm’s picture

Status: Active » Needs review
xjm’s picture

Issue summary: View changes

I gave plach "Write to VCS" permission on https://www.drupal.org/node/3060/maintainers so that he can commit this as his first commit once it's RTBC. :)

Status: Needs review » Needs work

The last submitted patch, 2: plach.patch, failed testing. View results

xjm’s picture

Status: Needs work » Needs review

#2921282: Promote the provisional product and framework managers hadn't been backported to 8.4.x somehow; I cherry-picked it now so this should apply again.

dawehner’s picture

The groups.drupal.org clearly lacks mentioning the ubernitpick award :)

dawehner’s picture

+++ b/core/MAINTAINERS.txt
@@ -39,7 +39,10 @@ Release managers
+  Framework managers
+  - Francesco Placella 'plach' https://www.drupal.org/u/plach

Here is one question. The other framework managers are categorized into backend and frontend. Should this category be applied to provisional members as well?

plach’s picture

The groups.drupal.org clearly lacks mentioning the ubernitpick award :)

Ha! Feel free to add a comment mentioning it ;)

Here is one question. The other framework managers are categorized into backend and frontend. Should this category be applied to provisional members as well?

That would make sense to me: I'm not planning to deal with frontend patches unless absolutely needed ;)

xjm’s picture

Here is one question. The other framework managers are categorized into backend and frontend. Should this category be applied to provisional members as well?

I just didn't want to indent it another time. ;) This is what it would look like:

Provisional membership

  Framework managers

    Backend
    - Francesco Placella 'plach' https://www.drupal.org/u/plach

I also tried this:

Framework managers

  Backend
  - Alex Bronstein 'effulgentsia' https://www.drupal.org/u/effulgentsia
  - Nathaniel Catchpole 'catch' https://www.drupal.org/u/catch
  - Alex Pott 'alexpott' https://www.drupal.org/u/alexpott
  - Lee Rowlands 'larowlan' https://www.drupal.org/u/larowlan

  Provisional membership
  - Francesco Placella 'plach' https://www.drupal.org/u/plach

  Frontend
  - Lauri Eskola 'lauriii' https://www.drupal.org/u/lauriii
  - Scott Reeves 'Cottser' https://www.drupal.org/u/cottser

...But I thought that was too confusing because of the way it separated the frontend framework managers from the "framework" header.

I guess we could do the attached, using the old format? Since it's generally going to be a short list.

plach’s picture

Looks better to me, thanks!

vaplas’s picture

@plach is one of the legendary persons! Yippee!

And I like the second version from @xjm. But I'd move the provisional line to the general list ;)

  Backend
  - Alex Bronstein 'effulgentsia' https://www.drupal.org/u/effulgentsia
  - Nathaniel Catchpole 'catch' https://www.drupal.org/u/catch
  - Alex Pott 'alexpott' https://www.drupal.org/u/alexpott
  - Lee Rowlands 'larowlan' https://www.drupal.org/u/larowlan
  - (provisional) Francesco Placella 'plach' https://www.drupal.org/u/plach

  Frontend
  - Lauri Eskola 'lauriii' https://www.drupal.org/u/lauriii
  - Scott Reeves 'Cottser' https://www.drupal.org/u/cottser

It solves problem with separated the frontend framework managers from the "framework" header. And it seems more clear and easy to find. For most cases, the status of the committer is not important, only category. Because any committer has influence and benefit.

xjm’s picture

@vaplas Being provisional does actually impact a number of things; see: https://www.drupal.org/core/maintainers/provisional-committers

Good suggestion though. Looks like our parameter documentation eh? :) Here's a patch for that, which puts provisional maintainers in the same section, at the end of the list for their section, with the word in front of their names. We'd also want to add that for the PHPunit initiative coordinators (the only other group that has provisional maintainers currently).

I did not realize this patch would be so challenging. :)

amateescu’s picture

@xjm, it's worth the effort though :P

Congratulation, @plach!!

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

I like this format especially, because it doesn't separate provisionals from others too much. MAINTAINERS.txt ideal purpose in the far future is to be able to look at it in order to find people to talk to. Given that keeping the list together makes sense.

  • webchick committed 26b822d on 8.5.x
    Issue #2922786 by xjm, dawehner, plach, vaplas: Add plach to MAINTAINERS...

  • webchick committed cc3a6fe on 8.4.x
    Issue #2922786 by xjm, dawehner, plach, vaplas: Add plach to MAINTAINERS...
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.5.x and cherry-picked to 8.4.x. YAY! :D

plach’s picture

+++ b/core/MAINTAINERS.txt
@@ -480,10 +479,8 @@ Media Initiative
-
-  Provisional membership:
-  - Len Swaneveld 'Lendude' https://www.drupal.org/u/lendude
-  - Michiel Nugter 'michielnugter' https://www.drupal.org/u/michielnugter
+  - (provisional) Michiel Nugter 'michielnugter' https://www.drupal.org/u/michielnugter
+  - (provisional) Len Swaneveld 'Lendude' https://www.drupal.org/u/lendude

Indentation is now off :D

vaplas’s picture

Fix #19 + other 'Provisional membership: None at this time.' labels.

plach’s picture

@vaplas:

Thanks for the patch and the suggestions above! What about opening a new issue dealing with the "provisional" members formatting? This issue was specifically about me and it's correctly marked as fixed now.

vaplas’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.