Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Actually the tests of ctools module seems fail @see https://www.drupal.org/pift-ci-job/807372 . That generate lot of noise and can disturb the correct issue validation process.
Proposed resolution
Resolve all Tests marked failled
Remaining tasks
We can start with Ctools.Drupal\ctools\Tests\Wizard\CToolsWizardTest that file seems generate few errors.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | resolve_failed_tests-2922552-16-interdiff.txt | 1019 bytes | Berdir |
| #16 | resolve_failed_tests-2922552-16.patch | 8.67 KB | Berdir |
| #15 | resolve_failed_tests-2922552-15.patch | 7.68 KB | Berdir |
| #12 | resolve_failed_tests-2922552-12.patch | 8.95 KB | howards |
| #9 | interdiff-2922552-9.txt | 3.14 KB | woprrr |
Comments
Comment #2
woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commentedThe first part of these error is due to #2820848: Make BlockContent entities publishable the entity key "published" = "status", are added on block_content entity and MASK does add it too.
Comment #3
woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commentedThis patch does fixe all problems with block_content changes.
Comment #5
woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commentedHere you are the correct path without follow-up patch added. To me all works well can you test it ?
Here the test for Drupal\ctools\Tests\Wizard\CToolsWizardTest only
Comment #7
woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commentedHere the final patch with Convert of WebTest to BrowserTest by the way ;) Now all will work :)
I add the patch with enhancer fix to see all errors are fixed with two patches.
Comment #9
woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commentedYAY ! All green with #2922297: Convert deprecated RouteEnhancerInterface use AND this patch applied :)
Just small adjust of coding standards issues.
I think everything is good now :)
Comment #10
geertvd CreditAttribution: geertvd at Geert van Dort commentedThis looks good to me. Great to have these green again!
Comment #11
woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commentedYes :) I love this green too. Can we merge both issue fast or you wait a precise date ?
Comment #12
howards CreditAttribution: howards commentedIt looks like part of this patch was already fixed in 8.x-3.x-dev via commit Update the masked BlockContent to mirror the upstream entity definition. The new patch removes that updated code in
modules/ctools_entity_mask/tests/modules/entity_mask_test/src/Entity/BlockContent.phpbecause it will not apply against the current -dev.Comment #13
DamienMcKennaComment #14
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedFor info, two other issues have been closed as duplicates of this one.
#2952280: Automated test fail: The entity type fake_block_content does not have a "published" entity key.
#2952284: CToolsWizardTest fail: Cannot find field with name 'one' and value 'New value'
Comment #15
BerdirI don't understand why this includes #2922297: Convert deprecated RouteEnhancerInterface use, that is only a deprecated usage fix and not an actual test fail, and it has its own dedicated issue.
Same for the wizard test, mixing test fixes and all those deprecated conversions makes it so much harder to review the actually necessary fix. Deprecations do *not* cause tests to fail on DrupalCI, they are just warnings.
I fixed the @coversDefaultClass causing the new fail, removed the RouteEnhancer part but kept the phpunit test conversion.
Comment #16
BerdirAlso fixing the block test.
Comment #18
joelpittetThanks @Berdir, that was easy to scan through and fixes the 8.6 test failures.
Comment #19
joelpittet@Berdir created a followup for D8.7 #3030158: Fix test fails for 8.7