Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I love this module. Thanks for writing and maintaining it!
I noticed a small but slightly annoying UI bug regarding the 'Show Raw Locations' setting. This setting is off by default. Instead of having the raw locations visible on page load and then using JS to hide them when so configured, it'd be a lot better to use the "js-hide" class in the raw page data, and use JS to reveal the list once JS loads.
In the non-JS case, the list will always be visible (like now).
Trivial patch against 8.x-1.x coming soon, stay tuned.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2921116-1.hide-raw-locations-by-default.patch | 2.35 KB | dww |
Comments
Comment #2
dwwComment #4
dwwI don't understand how those test failures relate to my patch. I didn't touch anything regarding Google Map API Keys.
Was this some weird transient test failure? Setting back to needs review to try to re-trigger the test bot...
Comment #5
dwwGreat, both re-tests worked, so I'm leaving this at 'Needs review'. Hope you agree this is a small, easy improvement.
Thanks again!
-Derek
Comment #7
ChristianAdamski CreditAttribution: ChristianAdamski at Wolters Kluwer commentedCommitted slightly altered.
Comment #8
dwwThanks!
Comment #9
dwwHrm, looking more closely at the patch you committed, now the raw locations will always be invisible for the non-JS case. Was that intentional? My patch tried to preserve the behavior for folks with JS disabled or otherwise unavailable. After commit 6da06c68587 those people will never see the raw locations, no matter what, since the original markup sent down the wire uses
display: noneand we only show it via JS. My approach sent the locations via a method that is only hidden if JS is enabled.Should I re-open this with another patch, or should I forget it and leave the non-JS people in the dark? ;)
Thanks!
-Derek