Some modules like RRSSB or AddThis do have some trouble with the extra icon from this module, see e.g. #2920800: Make sure it works nice with extlink module and #2834755: Issue with Addthis external links. This is not a bad thing, it's just that the two things are conflicting with each other.

The best way to solve this would be to introduce a small API in ExtLink which allows other modules to alter the CSS selectors for excluded links. That would be it. Are you interested in adding that to the module? I'd be happy to provide a patch if you wanted to.

CommentFileSizeAuthor
#4 2921077-4.extlink.Introduce-an-API-to-alter-settings.patch1.75 KBjurgenhaas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jurgenhaas created an issue. See original summary.

elachlan’s picture

elachlan CreditAttribution: elachlan commented

Do up a patch and I'll look at including it.

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Related issues: +#2920800: Make sure it works nice with extlink module, +#2834755: Issue with Addthis external links
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
CreditAttribution: jurgenhaas at LakeDrops, PARAGON Executive Services GmbH commented
Status: Active » Needs review
FileSize
2921077-4.extlink.Introduce-an-API-to-alter-settings.patch1.75 KB

@elachlan thanks for having a look at this. It turned out to be fairly easy to introduce such an API, the patch adds 2 lines of code and an API documentation file.

  • elachlan committed 6e6fd52 on 8.x-1.x authored by jurgenhaas 
    Issue #2921077 by jurgenhaas: Introduce an API to alter settings
elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.