Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xtal created an issue. See original summary.

Xtal’s picture

Xtal’s picture

Status: Active » Needs review

Status: Needs review » Needs work
Xtal’s picture

Title: Depreciated function » Inline form errors Depreciated link function
dev.patrick’s picture

I am working on this issue

dev.patrick’s picture

Status: Needs review » Needs work

The last submitted patch, 7: drupal-inline-form-errors-depreciated-function-2920571-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

dev.patrick’s picture

dev.patrick’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
swati.nuna’s picture

Hi,

Please check attached patch file.

Status: Needs review » Needs work

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andrewmacpherson’s picture

Title: Inline form errors Depreciated link function » Inline form errors Deprecated link function
chanderbhushan’s picture

added patch

Status: Needs review » Needs work

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Wim Leers’s picture

Category: Feature request » Task
Priority: Minor » Normal
Lendude’s picture

Status: Needs work » Needs review
FileSize
5.44 KB
5.47 KB

We should use toRenderable() and not toString(), and we can strip out the LinkGenerator and the Trait because that is now not used anymore.

No idea if this is stripping too much (tests are green locally..).

Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

Simplification FTW! 🤘

catch’s picture

Version: 8.6.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed a22498f and pushed to 8.7.x. Thanks!

  • catch committed a22498f on 8.7.x
    Issue #2920571 by dev.patrick, Lendude, Xtal, chanderbhushan: Inline...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.