Problem/Motivation

In core/modules/taxonomy/tests/src/Functional/Views/TaxonomyTermViewTest.php there's a local variable $language which is never created but never used in any context.

Proposed resolution

Remove unused local variable.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zaporylie created an issue. See original summary.

zaporylie’s picture

Status: Active » Needs review
FileSize
884 bytes

Let's see what DrupalCI thinks about removing it.

joelpittet’s picture

Status: Needs review » Reviewed & tested by the community

Nice cleaning house:)

  • xjm committed 7c4d8e4 on 8.5.x
    Issue #2920322 by zaporylie: Unused local variable in...

  • xjm committed ed09e43 on 8.4.x
    Issue #2920322 by zaporylie: Unused local variable in...
xjm’s picture

Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Yep, this looks good as per #2914677: Unused member variable in GlossaryViewTest. Committed to 8.5.x and also backported to 8.4.x since it's just a local variable.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.