Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

Status: Active » Needs review
FileSize
2.65 KB

How does this look?

DamienMcKenna’s picture

This should check for the public path and manual paths too, and adds some extra inline comments.

greggles’s picture

Title: Check backup directory permissions » Check backup directory permissions / web accessibility
David_Rothstein’s picture

I wonder if the Drupal 8 version of the module needs something like this as well.

It was pointed out to me that the README in Drupal 8 doesn't even mention the potential issue with web accessibility (whereas the Drupal 7 README does, under the headline "VERY IMPORTANT SECURITY NOTE"). I am not sure if that's an oversight, or if the module has changed in Drupal 8 such that it has other protections against this.

DamienMcKenna’s picture

DamienMcKenna’s picture

Also check that the individual files in the directory are not accessible.

DamienMcKenna’s picture

The last submitted patch, 7: backup_migrate-n2920311-7.patch, failed testing. View results

  • DamienMcKenna committed 775f846 on 7.x-3.x
    Issue #2920311 by DamienMcKenna: Check backup directory permissions /...
DamienMcKenna’s picture

Title: Check backup directory permissions / web accessibility » Check backup directory permissions / web accessibility (D7)
Status: Needs review » Fixed

Committed. We can do further work in other issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.