In hook_advagg_modify_css_pre_render_alter(), stylesheets are iterated over and the boolean $critical_css is set to determine whether any inline critical CSS has been added. If not, some functions are run through to determine whether deferring should be enabled or not. However, this code does not check for the newly added option which is meant to disable deferring of stylesheets if no critical CSS file is found.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | advagg-2919748-5-critical-css-pages-check.patch | 1.86 KB | kevineinarsson |
| #4 | advagg-2919748-4-critical-css-pages-check.patch | 1.75 KB | mikeytown2 |
| #2 | advagg_mod-file-controlled-deferring-2919748-2.patch | 1.62 KB | kevineinarsson |
Comments
Comment #2
kevineinarsson commentedAttached patch attempts to fix this by specifically checking if deferring has been set to use this option, and if so, return early.
I'm unsure if this should be part of
advagg_mod_css_defer_page(), but from what I can tell this function is meant to check if deferring is enabled or not, rather than the actual method being used. If this is not the case it should probably be done there.Comment #3
kevineinarsson commentedComment #4
mikeytown2 commentedThanks for the patch! How does this look to you? Put the check for the foreach loop.
Comment #5
kevineinarsson commentedThat makes sense, but there still needs to be a return if no file is found within this conditional. As otherwise the page still matches through
advagg_mod_match_path(), unless you have the variable advagg_mod_css_defer_pages set by having previously used the whitelist option.Comment #7
mikeytown2 commentedThanks for your work on this! It's been committed.