Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When the facet summary is built, the facets are built even if the facet has no active items. Skipping this on facets that take a long time to build would be an improvement in performance.
Comment | File | Size | Author |
---|---|---|---|
#3 | don_t_build_facet_in-2919705-3.patch | 830 bytes | mmrares |
Comments
Comment #2
borisson_This sounds like a great idea, if all the tests we have still pass we can indeed make a big win here.
We would need to have profiling data to back this up before this goes in (no matter what the patch is), so we can show off the improvements we made. Doing this with a tool such as boom/ab should be sufficient.
Comment #3
mmrares CreditAttribution: mmrares at AmeXio commentedComment #4
borisson_Setting to needs review so the testbot can see if something breaks.
Comment #5
borisson_Without patch:
With patch:
So there is a small increase in requests/second but not enough to notice. We should see if blackfire or xhprof gives us a better result - otherwise it looks like this doesn't really help.
Comment #6
mmrares CreditAttribution: mmrares at AmeXio commentedWe have a few facets with 300+ values where this patch helps. Do the tests include facets with a lot of values?
Comment #7
borisson_No, I only have ~20 nodes on my testsite. I'll try again tonight/tomorrow.
Comment #8
borisson_I now have a facet with ~50 items (generated terms)
With patch:
Yeah, this is an awesome improvement. Thanks so much!
Comment #9
StryKaizerThx!