It should be possible to bring this module into a Composer-built code base alongside Media Entity 1.x. This will be very helpful to the Media Initiative as we develop and test the cross-grade path to core Media. All we need to do is change Media Entity Image's composer.json to allow Media Entity 2.x as a dependency.

CommentFileSizeAuthor
#4 interdiff-2916854-2-4.txt865 bytesphenaproxima
#4 2916854-4.patch1.2 KBphenaproxima
#2 2916854-2.patch287 bytesphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
FileSize
2916854-2.patch287 bytes
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Needs review » Needs work

We discussed this on IRC and concluded that it would be great to have hook_requirements implementation that would prevent this from being enabled on 8.4 media setups.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
2916854-4.patch1.2 KB
interdiff-2916854-2-4.txt865 bytes

Added hook_requirements().

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Needs review » Fixed

Committed.

  • slashrsm committed 3264d04 on 8.x-1.x authored by phenaproxima 
    Issue #2916854 by phenaproxima, slashrsm: Allow inclusion in a Composer-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.