Problem/Motivation

Drupal issue: https://www.drupal.org/node/2018075 resolves the issue where inline floats are delegated out to the media-container wrapper; however the class applied is not consistent with the class used if the alignment is set through the media browser. If the alignment is set inline the class is media-float-{position}. If it is set via the media browser the class is media-wysiwyg-align-{position}. This results in inconsistencies for themed output such as margins, padding, etc.

Proposed resolution

Include the media-wysiwyg-align-{position} for alignments set inline.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

adam-delaney created an issue. See original summary.

adam-delaney’s picture

Version: 7.x-3.x-dev » 7.x-2.x-dev

Updating version for the version I'm testing with.

joseph.olstad’s picture

what base theme are you using?
is it bootstrap?
or other?

joseph.olstad’s picture

Category: Bug report » Support request
adam-delaney’s picture

I am using Radix, however I have been able to replicate the issue using Bartik. I don't see any preprocessing of classes within any modules that I am using that would modify the default class implemented by media_browser. The CSS is being called from media/modules/media_wysiwyg/css/media_wysiwyg.base.css, i.e. .media-wysiwyg-align-left { }, which means it is agnostic from any theme styles.

joseph.olstad’s picture

ok, so if you propose a css adjustment for this, a patch could be made from that and thus reviewed.

adam-delaney’s picture

Here's a patch that adds the midea-float-{position} selector to the corresponding css declarations in media_wysiwyg.base.css.

adam-delaney’s picture

Status: Active » Needs review

  • adam-delaney authored b81337e on 7.x-2.x
    Issue #2913361 by adam-delaney: Media inline filter float classes are...

  • adam-delaney authored b81337e on 7.x-3.x
    Issue #2913361 by adam-delaney: Media inline filter float classes are...
joseph.olstad’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.