LocalTaskDefault/LocalActionDefault ignore parameters when raw parameters are not present.

Overall looks like a good fix, but a few small fixes would make this great.

Let's rename the variables in the method something like:

• $parameters -> $route_parameters
• $raw_variables -> $raw_parameters
• $variables -> $parameters

Also it would be really helpful to have a code comment explaining when and how it's possible to have a parameter (the upcast value) that's not present in the raw parameters. Tim Plunkett helpfully explained in person that the parameter (variable/slug name) could be in the route defaults and empty, or could be an optional (trailing) slug in the path and in either case the value was populated by a route enhancer.

Looks great, thanks for adding to the code comments and creating the refactor issue.

Since this breaks layouts, making major.

Committed and pushed a4cedd8c75 to 8.7.x and b53b0daabd to 8.6.x. Thanks!

As a bug fix backported to 8.6.x.

diff --git a/core/lib/Drupal/Core/Menu/LocalActionDefault.php b/core/lib/Drupal/Core/Menu/LocalActionDefault.php
index 246e844a77..5e161ec1de 100644
--- a/core/lib/Drupal/Core/Menu/LocalActionDefault.php
+++ b/core/lib/Drupal/Core/Menu/LocalActionDefault.php
@@ -91,8 +91,8 @@ public function getRouteParameters(RouteMatchInterface $route_match) {
     // run, and the route parameters have been upcast. The original values can
     // be retrieved from the raw parameters. For example, if the route's path is
     // /filter/tips/{filter_format} and the path is /filter/tips/plain_text then
-    // $raw_variables->get('filter_format') == 'plain_text'. Parameters that are
-    // not represented in the route path as slugs might be added by a route
+    // $raw_parameters->get('filter_format') == 'plain_text'. Parameters that
+    // are not represented in the route path as slugs might be added by a route
     // enhancer and will not be present in the raw parameters.
     $raw_parameters = $route_match->getRawParameters();
     $parameters = $route_match->getParameters();
diff --git a/core/lib/Drupal/Core/Menu/LocalTaskDefault.php b/core/lib/Drupal/Core/Menu/LocalTaskDefault.php
index ab7cd5ce8d..49a7a2cc68 100644
--- a/core/lib/Drupal/Core/Menu/LocalTaskDefault.php
+++ b/core/lib/Drupal/Core/Menu/LocalTaskDefault.php
@@ -49,8 +49,8 @@ public function getRouteParameters(RouteMatchInterface $route_match) {
     // run, and the route parameters have been upcast. The original values can
     // be retrieved from the raw parameters. For example, if the route's path is
     // /filter/tips/{filter_format} and the path is /filter/tips/plain_text then
-    // $raw_variables->get('filter_format') == 'plain_text'. Parameters that are
-    // not represented in the route path as slugs might be added by a route
+    // $raw_parameters->get('filter_format') == 'plain_text'. Parameters that
+    // are not represented in the route path as slugs might be added by a route
     // enhancer and will not be present in the raw parameters.
     $raw_parameters = $route_match->getRawParameters();
     $parameters = $route_match->getParameters();

Looks like we need to update the code in the comments too. Fixed on commit.