Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
In #2901572: Fix 'Drupal.Commenting.PostStatementComment' coding standard and related issues we noticed this:
$this->assertEqual($expected, $metadata); //, 'The correct metadata (including custom metadata) is generated.');
Proposed resolution
Follow the steps in #2909362: [meta] Commented-out code in Drupal to determine why this comment is there and whether it is safe to remove it.
Remaining tasks
- Use
git log -L
. - Determine why this comment is there and whether it is safe to remove it.
Comment | File | Size | Author |
---|---|---|---|
#7 | drupal-weird-comments-2911164-7.patch | 689 bytes | mfernea |
#3 | drupal-weird-comments-2911164-3.patch | 688 bytes | mfernea |
Comments
Comment #2
mfernea CreditAttribution: mfernea at AmeXio commentedThis was introduced by the patch at https://www.drupal.org/node/1874640#comment-8685511. There's no mention in the issue about this type of change. It's the only place in the patch where an assertEqual call was modified. The message looks ok to me. Similar messages are used in the same class:
So, I would keep it.
Comment #3
mfernea CreditAttribution: mfernea at AmeXio commentedHere is the patch.
Comment #4
mfernea CreditAttribution: mfernea at AmeXio commentedStatus change for bots.
Comment #5
jofitz CreditAttribution: jofitz at ComputerMinds commentedThis seems like a sensible conclusion considering the similar usage in the same file.
Comment #6
larowlanNo longer applies
Comment #7
mfernea CreditAttribution: mfernea at AmeXio commentedRe-roll.
Comment #8
jofitz CreditAttribution: jofitz at ComputerMinds commentedSimple re-roll, patch functionally still the same. Back to RTBC.
Comment #9
Gábor HojtsyComment #12
Gábor HojtsyThanks, committed to 8.5.x and cherry-picked to 8.4.x.