The JS attached for webforms uses #edit-draft, but the id of the draft button is now #edit-actions-draft, so the JS isn't attaching.
Consequences are that clientside validation fires on save draft, even if the user has disabled the setting.

Patch will be attached!

CommentFileSizeAuthor
#5 patch_disable-2910472-5.patch724 bytesjrockowitz
#4 2910472.patch572 bytesmattgill
#3 2910472.patch485 bytesmattgill
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mattgill created an issue. See original summary.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented

Please make sure the patch still supports < 8.3.x with a @todo to remove the old 8.3.x selector once only 8.4.+ is only supported.

BTW, I might be wrong that this is 8.4.x related issue.

mattgill’s picture

mattgill CreditAttribution: mattgill as a volunteer commented
FileSize
2910472.patch485 bytes

Oops! Just saw your comment... new patch incoming :)

mattgill’s picture

mattgill CreditAttribution: mattgill as a volunteer commented
FileSize
2910472.patch572 bytes

New patch updated as requested :)

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
FileSize
patch_disable-2910472-5.patch724 bytes

Patch looks fine.

I am wondering if we even need Drupal.behaviors.webformDraft since Drupal.behaviors.webformSubmitNoValidate is being triggered via .js-webform-novalidate.

See attached patched.

  • jrockowitz committed 52933f8 on 8.x-5.x 
    Issue #2910472 by mattgill, jrockowitz: Patch - Disable validate when...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs review » Fixed

I committed the patch. Please download the latest dev release to review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.