Better then duplicating a static string ... e.g boa uses a different path.

CommentFileSizeAuthor
#2 make_var_aegir_variable-2909095-2.patch2.31 KBhelmo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

helmo created an issue. See original summary.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commented
Status: Active » Needs review
FileSize
make_var_aegir_variable-2909095-2.patch2.31 KB
Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location New Windsor NY
CreditAttribution: Jon Pugh at OpenDevShop Inc (CLOSED) commented 
+    $ssh_config_dir = d($task->ref->title)->aegir_root . '/.ssh/';

We should stay in the active context, shouldn't we? d() is hostmaster because it is a post-task hook. Who knows what aegir_root might be set to in other sites. I think it's more reliable to just use d().

+    $ssh_config_dir = d()->aegir_root . '/.ssh/';

I'm also wondering where that gets set from originally...

Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location New Windsor NY
CreditAttribution: Jon Pugh at OpenDevShop Inc (CLOSED) commented

Awesome... if you push a branch with the issue ID in front, it automatically shows up over there ------>

@helmo please commit and push to branch 2909095-var-aegir-variable for review.

  • helmo committed e01630e on 2909095-var-aegir-variable 
    Issue #2909095: Make /var/aegir/ variable, e.g. needed for boa
helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commented

Well, we could change it to $ssh_config_dir = d()->server->aegir_root . '/.ssh/';

But what about slave servers? This is run in hostmaster site context. So the example above would always work on the server where hostmaster is, even though it could be another server node being verified.