Move temporary files to temporary scheme [#2908953]

Comment	File	Size	Author
#15	solve_cron_null-2908953-15.patch	8.38 KB	VanHomero
#14	update_patch_12_to_rc3_version-2908953-14.patch	8.3 KB	VanHomero
#12	move_files_upload-2908953-12.patch	8.82 KB	VanHomero
#11	fix_method_copytree-2908953-11.patch	7.75 KB	VanHomero
#10	move_method_copytree-2908953-10.patch	7.75 KB	VanHomero
#9	validation_new_node-2908953-9.patch	7.79 KB	VanHomero
#8	show_images_editor-2908953-8.patch	7.63 KB	VanHomero
#7	improve_temporary_files_handled-2908953-7.patch	6.31 KB	VanHomero
#6	update-temporary-2908953-6.patch	6.47 KB	VanHomero
#5	new-changes-temporary-files-2908953-5.patch	6.24 KB	VanHomero
#3	move-temporary-fields-2908953-3.patch	2.17 KB	VanHomero

Comment #1

14 September 2017 at 20:16

VanHomero created an issue. See original summary.

Log in or register to post comments

Comment #2

VanHomero CreditAttribution: VanHomero as a volunteer commented 14 September 2017 at 20:21

Issue summary:

View changes

Log in or register to post comments

Comment #3

VanHomero CreditAttribution: VanHomero as a volunteer commented 14 September 2017 at 20:51

File	Size
move-temporary-fields-2908953-3.patch	2.17 KB

Modify the classes H5PEditorDrupalStorage, H5PEditorDrupalStorage and H5PUploadWidget to move the files uploaded to the temporary directory.

Log in or register to post comments

Comment #4

icc CreditAttribution: icc commented 15 September 2017 at 07:46

I've created an issue in the H5P tracker to ensure that the patch gets applied before the stable version is released: HFP-1500

Log in or register to post comments

Comment #5

VanHomero CreditAttribution: VanHomero as a volunteer commented 17 September 2017 at 20:43

File	Size
new-changes-temporary-files-2908953-5.patch	6.24 KB

I add a new changes to improve the load of the files.

Log in or register to post comments

Comment #6

VanHomero CreditAttribution: VanHomero as a volunteer commented 17 September 2017 at 21:33

File	Size
update-temporary-2908953-6.patch	6.47 KB

Update the path to storage files.

Log in or register to post comments

Comment #7

VanHomero CreditAttribution: VanHomero as a volunteer commented 17 September 2017 at 22:47

File	Size
improve_temporary_files_handled-2908953-7.patch	6.31 KB

Improve the way that the temporary works with the class H5PWidgetBase.

Log in or register to post comments

Comment #8

VanHomero CreditAttribution: VanHomero as a volunteer commented 18 September 2017 at 20:45

File	Size
show_images_editor-2908953-8.patch	7.63 KB

When a media file is uploaded the file doesn't show in the editor until we save the node. So this patch show complete the last patch with the migration files from temporary to public.

Log in or register to post comments

Comment #9

VanHomero CreditAttribution: VanHomero as a volunteer commented 19 September 2017 at 03:20

File	Size
validation_new_node-2908953-9.patch	7.79 KB

Add a validation for the upload files in new nodes.

Log in or register to post comments

Comment #10

VanHomero CreditAttribution: VanHomero as a volunteer commented 19 September 2017 at 19:36

File	Size
move_method_copytree-2908953-10.patch	7.75 KB

Move method copyTree from H5PDefaultFormatter to H5PDrupal.

Log in or register to post comments

Comment #11

VanHomero CreditAttribution: VanHomero as a volunteer commented 20 September 2017 at 00:57

File	Size
fix_method_copytree-2908953-11.patch	7.75 KB

Fix the method copyTree in H5PDrupal class.

Log in or register to post comments

Comment #12

VanHomero CreditAttribution: VanHomero as a volunteer commented 20 September 2017 at 23:55

File	Size
move_files_upload-2908953-12.patch	8.82 KB

Move files when a H5P is uploaded.

Log in or register to post comments

Comment #13

icc CreditAttribution: icc commented 28 September 2017 at 13:03

Is there any particular reason you wish to use the temporary:// store? It seems a bit unnecessary to store it in temp first and then move it to the public area.
Also, it would be nice if you could add some comments to the code specifying what the code does and why. It will make it easier to understand.

This is a solution – the initial issue/problem description is missing.

Log in or register to post comments

Comment #14

VanHomero CreditAttribution: VanHomero as a volunteer commented 17 November 2017 at 18:36

File	Size
update_patch_12_to_rc3_version-2908953-14.patch	8.3 KB

I'm using a nfs and a load balancer if I write in the public the nfs can't replicate all the files to all the servers conected to the load balancer. The patch is fix to the 8.x-1.0-rc3.

Log in or register to post comments

Comment #15

VanHomero CreditAttribution: VanHomero as a volunteer commented 5 December 2017 at 15:40

File	Size
solve_cron_null-2908953-15.patch	8.38 KB

The solution for #comment-14 has an issue with the cron job. This new patch fix it.

Log in or register to post comments

Comment #16

paalj CreditAttribution: paalj commented 7 December 2017 at 13:31

I think some of the changes you have done clearly shows H5P need some refactoring/redesign before this can be implemented in a clean way. We are looking into how to use S3 or similar to store files. I hope the changes need for that will do the trick.

In the meantime, I guess you would have to live with your patches :(