This is a child issue of #2906470: Orphan comments and entries in comment_entity_statistics after comment field instance has been deleted. Based on the recommendation by @andypost and @larowlan, this UI part should be handled as a separate child issue.

Problem/Motivation

When a comment field instance is deleted for example from a node content type, we are currently showing the warning below.
Current warning

The site builder is currently not being explicitly warned that deleting the comment field will also delete all the comments of that comment field instance.

Proposed resolution

In addition to the current "Are you sure you want to delete the field {Comment field name}? This action cannot be undone." warning, the site builder should be shown a message: All comments of this comment field will be deleted.

If we want to make this more generic and to improve the site builder UX for all field deletions, we could re-phrase the This action cannot be undone warning as All content of this field will be permanently deleted. This action cannot be undone.

Remaining tasks

  • Decide if we want to make Comment module specific warning or improve this so that the same warning will be shown for all field deletions.
  • Patch
  • Review
  • Commit

User interface changes

Yes, see proposed resolution above.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2908607-current-warning.png27.05 KBmasipila
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

masipila created an issue. See original summary.

masipila’s picture

Issue summary: View changes
FileSize
27.05 KB
andypost’s picture

Issue tags: +Needs tests

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.