Add support for managing multiple webforms attached to a single node [#2908300]

Problem

It is possible to add multiple webforms to a node a multiple value field and/or two webform field. Currently, when two webforms are associated with one node, the first webform is considered the primary (and only) webform.

Solution

Add Webform dropdown menu to a webform node's 'Test' and 'Results' (Submissions, Download, Clear) tabs.

Tasks

Add WebformEntityReferenceItem::getEntityWebformId
Add WebformEntityReferenceItem::getEntityWebformFieldNames
Add WebformEntityReferenceItem::hasEntityWebformMultiple
Check for WebformEntityReferenceItem::hasEntityWebformMultiple and disable Webform Node tabs.
Add $_SESSION checking to ::getEntityWebformFieldName
Place Webform dropdown menu using hook_preprocess_page_title().

Comment	File	Size	Author
#22	Screen Shot 2017-09-16 at 6.31.58 AM.png	166.96 KB	jrockowitz
#20	add_support_for-2908300-20.patch	83.84 KB	jrockowitz
#20	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 598 pass
#17	add_support_for-2908300-17.patch	81.59 KB	jrockowitz
#17	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass
#14	add_support_for-2908300-14.patch	76.71 KB	jrockowitz
#14	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass
#12	add_support_for-2908300-11.patch	74.07 KB	jrockowitz
#12	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass
#9	add_support_for-2908300-9.patch	72.55 KB	jrockowitz
#9	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 590 pass, 13 fail
#7	add_support_for-2908300-7.patch	64.72 KB	jrockowitz
#7	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass
#4	add_support_for-2908300-3.patch	25.12 KB	jrockowitz
#4	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 593 pass, 2 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

12 September 2017 at 14:51

jrockowitz created an issue. See original summary.

Comment #2

12 September 2017 at 21:50

65f063b committed on 2908300-multiple-webform-node

Issue #2908300: Add support for managing multiple webforms attached to a...

Comment #3

13 September 2017 at 16:47

jrockowitz committed 348a1c0 on 2908300-multiple-webform-node

Issue #2908300: Add support for managing multiple webforms attached to a...

Comment #4

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 September 2017 at 16:49

Issue summary:	View changes
Status:	Active	» Needs review

File	Size
add_support_for-2908300-3.patch	25.12 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 593 pass, 2 fail

This issue is going to require some major refactoring, so I am going to have to post a few patches that need to be tested via the test bot.

Comment #5

13 September 2017 at 17:06

Status:

Needs review

» Needs work

The last submitted patch, 4: add_support_for-2908300-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #6

14 September 2017 at 12:53

jrockowitz committed e8d0e6b on 2908300-multiple-webform-node

Issue #2908300: Add support for managing multiple webforms attached to a...

Comment #7

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 14 September 2017 at 12:54

Status:

Needs work

» Needs review

File	Size
add_support_for-2908300-7.patch	64.72 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass

Comment #8

14 September 2017 at 14:00

jrockowitz committed d44a820 on 2908300-multiple-webform-node

Issue #2908300: Add support for managing multiple webforms attached to a...

Comment #9

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 14 September 2017 at 14:00

File	Size
add_support_for-2908300-9.patch	72.55 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 590 pass, 13 fail

Comment #10

14 September 2017 at 14:14

Status:

Needs review

» Needs work

The last submitted patch, 9: add_support_for-2908300-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #11

14 September 2017 at 14:41

jrockowitz committed 60a7542 on 2908300-multiple-webform-node

Issue #2908300: Add support for managing multiple webforms attached to a...

Comment #12

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 14 September 2017 at 14:41

Status:

Needs work

» Needs review

File	Size
add_support_for-2908300-11.patch	74.07 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass

Comment #13

14 September 2017 at 17:21

jrockowitz committed 59bc960 on 2908300-multiple-webform-node

Issue #2908300: Add support for managing multiple webforms attached to a...

Comment #14

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 14 September 2017 at 17:22

File	Size
add_support_for-2908300-14.patch	76.71 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass

Comment #15

15 September 2017 at 14:47

jrockowitz committed 940dd18 on 2908300-multiple-webform-node

Issue #2908300 by jrockowitz: Add support for managing multiple webforms...

Comment #16

15 September 2017 at 15:10

jrockowitz committed 3373ec1 on 2908300-multiple-webform-node

Issue #2908300 by jrockowitz: Add support for managing multiple webforms...

Comment #17

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 15 September 2017 at 15:11

File	Size
add_support_for-2908300-17.patch	81.59 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass

Comment #18

15 September 2017 at 16:51

jrockowitz committed 3754469 on 2908300-multiple-webform-node

Issue #2908300 by jrockowitz: Add support for managing multiple webforms...

Comment #19

15 September 2017 at 16:54

jrockowitz committed 55dc1ba on 2908300-multiple-webform-node

Issue #2908300 by jrockowitz: Add support for managing multiple webforms...

Comment #20

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 15 September 2017 at 16:55

File	Size
add_support_for-2908300-20.patch	83.84 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 598 pass

Comment #21

16 September 2017 at 10:28

jrockowitz committed 1b74f15 on 8.x-5.x

Issue #2908300 by jrockowitz: Add support for managing multiple webforms...

Comment #22

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 16 September 2017 at 10:33

File	Size
Screen Shot 2017-09-16 at 6.31.58 AM.png	166.96 KB

I committed the patch. Please download the latest dev release to review.

Below is a screenshot of the toggle webform reference.

Comment #23

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 16 September 2017 at 10:34

Status:

Needs review

» Fixed

Comment #24

30 September 2017 at 10:35

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #25

frau.wolf CreditAttribution: frau.wolf commented 26 August 2018 at 14:51

8 files were hidden/shown/deleted

File	Size
add_support_for-2908300-3.patch	25.12 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 593 pass, 2 fail
add_support_for-2908300-7.patch	64.72 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass
add_support_for-2908300-9.patch	72.55 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 590 pass, 13 fail
add_support_for-2908300-11.patch	74.07 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass
add_support_for-2908300-14.patch	76.71 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass
add_support_for-2908300-17.patch	81.59 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 595 pass
add_support_for-2908300-20.patch	83.84 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 598 pass
Screen Shot 2017-09-16 at 6.31.58 AM.png	166.96 KB

@jrockowitz Thank you so much for implementing this feature, it still needs a bit of work though.

I just tried to attach two webforms to a node, and fill them out as authenticated user and anonymous user. In the results of the node itself it only shows the submissions for the primary (first) webform. All 4 submissions are stored and can be accessed in the general Webforms: Submissions tab.
Screenshots can be found here: https://imgur.com/a/v8tmsct