Problem/Motivation

Currently the ns.basePath has a trailing slash which is causing double slash on including assets like config.js, en.js files like http://d7/sites/all/modules/contrib/h5p/modules/h5peditor/h5peditor//ckeditor/config.js?t=F7J9. This causes issues when we have redirect module as they try to redirect to cleaned up/ correct URL.

Proposed resolution

Remove the trailing slash so that the asset get correct URL for the first time.

Remaining tasks

User interface changes

Original report

While editing the content type created using H5P module, some of the files are being loaded under non-secure protocol in https sites, which is causing the mixed . PFA screeenshot(issue)

Please follow these steps to replicate the issue:

  • Select the content type “Interactive content"
  • Type in the title of the page
  • Under “ Content type ” use one content type( For ex: Multiple Choice).
  • It then gives you a form to fill in with the questions and the answers but I am not able to type in to the text fields.

By this way, you can able to see the mixed content error in the console.

CommentFileSizeAuthor
#13 fix js url-2908218-13.patch1.19 KBNoor Eldin Essam
#4 2908218-4.patch692 bytesvijaycs85
issue.png137.41 KBRajamSethuraj
issue_firefox.png140.72 KBRajamSethuraj
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RajamSethuraj created an issue. See original summary.

icc’s picture

icc CreditAttribution: icc commented

Hi,

Could you please open your browser's console(Ctrl+Shift+J in Chrome) and double check the values of the Drupal.settings.basePath variable?
I'm suspecting you base URL may contain the wrong protocol for some reason. If you haven't set this your self it may be a module doing it.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Title: Mixed content issue while editing the content type using H5P module » Trailing slash on basePath causing issues.
Issue summary: View changes
Issue tags: -h5p
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Active » Needs review
Issue tags: +Novice
FileSize
2908218-4.patch692 bytes

Here is the patch

sidharthap’s picture

sidharthap
Primary language English
CreditAttribution: sidharthap at TATA Consultancy Services for Pfizer, Inc. commented

Thank you #vijaycs85
#4 works for me.

imkartik’s picture

imkartik CreditAttribution: imkartik at TATA Consultancy Services for Pfizer, Inc. commented

The patch looks good. Changing the status for this issue.

imkartik’s picture

imkartik CreditAttribution: imkartik at TATA Consultancy Services for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

The patch looks good. Changing the status for this issue.

icc’s picture

icc CreditAttribution: icc commented

I've created an issue for adding the patch to the next version of the module: HFP-1524

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented

Thanks @icc!

rajeev_drupal’s picture

rajeev_drupal CreditAttribution: rajeev_drupal at TATA Consultancy Services for Pfizer, Inc. commented

We have faced this issue on one of our production site, and this patch is working well for that issue.
Thanks @vijaycs85

RajamSethuraj’s picture

RajamSethuraj CreditAttribution: RajamSethuraj commented
Status: Reviewed & tested by the community » Fixed

Thanks for the help. Issue was fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Noor Eldin Essam’s picture

Noor Eldin Essam
Primary language Arabic
CreditAttribution: Noor Eldin Essam commented
FileSize
fix js url-2908218-13.patch1.19 KB

Fix issue for js library url