Problem/Motivation

Webform puts the whole form structure into a single string which can't be translated automatically by TMGMT

Proposed resolution

Similar to #2853516: Custom field types are not exported properly if stored in a non atomic way (eg. metatags), add the possibility of a custom processor per config schema type.

Remaining tasks

Tests, save translation data.

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Status: Active » Needs review
FileSize
9.83 KB

Status: Needs review » Needs work

The last submitted patch, 2: support_translation_of-2908120-2.patch, failed testing. View results

Berdir’s picture

Title: Support translation of weform form elements » Support translation of webform form elements
Status: Needs work » Needs review
FileSize
18.63 KB

Also implemented saving of the translation, fixed the PHP7 syntax which should fix the phplint error and wrote a basic test.

Berdir’s picture

Todo:

* Refactor the processor so we have less to overwrite, possibly support # replacement on all elements, maybe use a different replacement
* Think about tokens, maybe support escaping, skip elements that only have a token completely (or actually, make them not translatable)

Status: Needs review » Needs work

The last submitted patch, 4: support_translation_of-2908120-4.patch, failed testing. View results

Berdir’s picture

Wrong webform dev dependency.

Berdir’s picture

Added support for parent keys with a #, e.g. select options.

Berdir’s picture

Added support to skip values with only a token from the translation entirely.

Status: Needs review » Needs work

The last submitted patch, 9: support_translation_of-2908120-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Berdir’s picture

Was testing with an older webform version, they actually changed that token. Lets hope they don't do that again :)

Berdir’s picture

The last submitted patch, 11: support_translation_of-2908120-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • Berdir committed 24a1a1c on 8.x-1.x
    Issue #2908120 by Berdir: Support translation of webform form elements
    
Berdir’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.