As entityManager() method will be removed before D9 release. So replace it with entityTypeManager()

CommentFileSizeAuthor
#14 2907536-14.patch3.15 KBandypost
#14 interdiff-5-15.txt2.89 KBandypost
#8 replace_entity_manager.png31.36 KBVenkatesh Rajan.J
#5 remove_deprecated-2907536_1.patch1.95 KBbapi_22
#2 remove_deprecated-2907536.patch641 bytesbapi_22
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bapi_22 created an issue. See original summary.

bapi_22’s picture

bapi_22 CreditAttribution: bapi_22 at Cybage Software Pvt Ltd. commented
Status: Needs work » Needs review
FileSize
remove_deprecated-2907536.patch641 bytes
bapi_22’s picture

bapi_22 CreditAttribution: bapi_22 at Cybage Software Pvt Ltd. commented
Assigned: bapi_22 » Unassigned
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Needs work

There are 6 other references to entity manager in the module.

Let's do them all in one go.

Thanks

bapi_22’s picture

bapi_22 CreditAttribution: bapi_22 at Cybage Software Pvt Ltd. commented
FileSize
remove_deprecated-2907536_1.patch1.95 KB

Hi Larowlan,

One more EntityManagerInterface I found in the MessageEditForm. Instead of replacing it into EntityTypeManagerInterface, I have removed it, as it's already injected in parent class.

Uploading the updated patch.

Thanks,

bapi_22’s picture

bapi_22 CreditAttribution: bapi_22 at Cybage Software Pvt Ltd. commented
Status: Needs work » Needs review
Venkatesh Rajan.J’s picture

Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at DrupalPartners commented
Assigned: Unassigned » Venkatesh Rajan.J
Venkatesh Rajan.J’s picture

Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at DrupalPartners commented
FileSize
replace_entity_manager.png31.36 KB

Patch applied successfully. Refer the screenshot

Venkatesh Rajan.J’s picture

Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at DrupalPartners commented
Assigned: Venkatesh Rajan.J » Unassigned
Status: Needs review » Reviewed & tested by the community
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue summary: View changes 
+++ b/src/MessageEditForm.php
@@ -23,13 +22,10 @@ class MessageEditForm extends ContentEntityForm {
-  public function __construct(EntityManagerInterface $entity_manager, LanguageManagerInterface $language_manager) {
-    parent::__construct($entity_manager);
+  public function __construct(LanguageManagerInterface $language_manager) {

btw parent class require it, looks you should call parent constructor as well

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Reviewed & tested by the community » Needs work

Constructor of parent is slightly different in 8,7 core

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Parent issue: » #3018997: Plan for next Contact Storage release
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

$this->languageManager is actually unused, so we can remove that property and the constructor completely, that will be compatible with all versions.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Reviewed & tested by the community
FileSize
interdiff-5-15.txt2.89 KB
2907536-14.patch3.15 KB

I found no other usage + fixed #13

  • larowlan committed f9f653d on 8.x-1.x authored by andypost 
    Issue #2907536 by bapi_22, andypost, Venkatesh Rajan.J, Berdir, larowlan...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Thanks 🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.