I get the following warning when I regenerate the sitemap. The error goes away when I comment out the "use StringTranslationTrait;" line in "BatchUrlGenerator.php". The line duplicates the same line in the extended class ("Drupal\simple_sitemap\Batch\BatchUrlGenerator").

Strict warning: Drupal\simple_sitemap\Batch\BatchUrlGenerator and Drupal\Core\StringTranslation\StringTranslationTrait define the same property ($stringTranslation) in the composition of Drupal\domain_simple_sitemap\Batch\BatchUrlGenerator. This might be incompatible, to improve maintainability consider using accessor methods in traits instead. Class was composed in require() (line 319 of modules/contrib/domain_simple_sitemap/src/Batch/BatchUrlGenerator.php).

CommentFileSizeAuthor
#2 domain-simple-sitemap-batchurlgenerator-strict-warning.patch522 bytesslbrassard

Comments

slbrassard created an issue. See original summary.

slbrassard’s picture

slbrassard commented
StatusFileSize
new domain-simple-sitemap-batchurlgenerator-strict-warning.patch522 bytes
jeni_dc’s picture

jeni_dc commented

I've tested the patch against 8.x-1.0-rc1 and it's working fine here. The error is removed when generating the sitemap and the sitemaps per domain are generated as expected.

keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented
Status: Active » Fixed

Fixed and released new version.

Please: slbrassard, jeni_dcnext next time change issue status :)

keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented

.

  • keopx committed 10ed34f on 8.x-1.x authored by slbrassard 
    Issue #2907405 by slbrassard, jeni_dc: BatchUrlGenerator strict warning...
keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented
Status: Fixed » Closed (fixed)