Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Items:
FILE: ...al_DCOH/Drupal/sites/all/modules/xmlsitemap/xmlsitemap.admin.inc
----------------------------------------------------------------------
FOUND 47 ERRORS AND 4 WARNINGS AFFECTING 38 LINES
----------------------------------------------------------------------
38 | ERROR | [x] No space found before comment text; expected "//
| | '#validate' =>
| | array('xmlsitemap_sitemap_list_form_validate'),"
| | but found "//'#validate' =>
| | array('xmlsitemap_sitemap_list_form_validate'),"
39 | ERROR | [x] No space found before comment text; expected "//
| | '#submit' =>
| | array('xmlsitemap_sitemap_list_form_submit'),"
| | but found "//'#submit' =>
| | array('xmlsitemap_sitemap_list_form_submit'),"
39 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
51 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
85 | WARNING | [x] There must be no blank line following an inline
| | comment
85 | ERROR | [x] No space found before comment text; expected "//
| | $options[$smid]['#attributes']['class'][] =
| | 'warning';" but found
| | "//$options[$smid]['#attributes']['class'][] =
| | 'warning';"
154 | WARNING | [ ] Line exceeds 80 characters; contains 128
| | characters
154 | ERROR | [x] No space found before comment text; expected "//
| | watchdog('xmlsitemap', '@action @count XML
| | sitemaps.', array('@action' =>
| | $operation['action past'], '@count' =>
| | $count));" but found "//watchdog('xmlsitemap',
| | '@action @count XML sitemaps.', array('@action'
| | => $operation['action past'], '@count' =>
| | $count));"
154 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
156 | ERROR | [x] No space found before comment text; expected "//
| | $form_state['redirect'] =
| | 'admin/config/search/xmlsitemap';" but found
| | "//$form_state['redirect'] =
| | 'admin/config/search/xmlsitemap';"
156 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
160 | ERROR | [x] Missing function doc comment
199 | ERROR | [x] Missing function doc comment
210 | ERROR | [x] Missing function doc comment
220 | ERROR | [x] Missing function doc comment
228 | ERROR | [x] Missing function doc comment
251 | ERROR | [x] Missing function doc comment
267 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
291 | ERROR | [x] No space found before comment text; expected "//
| | $form['advanced']['xmlsitemap_gz'] = array(" but
| | found "//$form['advanced']['xmlsitemap_gz'] =
| | array("
296 | ERROR | [x] No space found before comment text; expected "//
| | );" but found "//);"
296 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
300 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
308 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
365 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
428 | ERROR | [x] Doc comment short description must end with a
| | full stop
574 | ERROR | [x] No space found before comment text; expected "//
| | if (!isset($bundle) &&
| | isset($entity_info['bundle keys']['bundle'])) {"
| | but found "//if (!isset($bundle) &&
| | isset($entity_info['bundle keys']['bundle'])) {"
574 | ERROR | [x] Inline comments must start with a capital letter
577 | ERROR | [ ] Comment indentation error, expected only 2
| | spaces
580 | ERROR | [ ] Comment indentation error, expected only 2
| | spaces
582 | WARNING | [x] There must be no blank line following an inline
| | comment
582 | ERROR | [x] No space found before comment text; expected "//
| | }" but found "//}"
582 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
644 | ERROR | [x] Missing function doc comment
652 | ERROR | [x] There should be no white space after an opening
| | "("
728 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
759 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
789 | ERROR | [x] No space found before comment text; expected "//
| | $form['xmlsitemap']['lastmod'] = array(" but
| | found "//$form['xmlsitemap']['lastmod'] =
| | array("
792 | ERROR | [x] No space found before comment text; expected "//
| | );" but found "//);"
793 | ERROR | [x] No space found before comment text; expected "//
| | $form['xmlsitemap']['changefreq'] = array(" but
| | found "//$form['xmlsitemap']['changefreq'] =
| | array("
796 | ERROR | [x] No space found before comment text; expected "//
| | );" but found "//);"
797 | ERROR | [x] No space found before comment text; expected "//
| | $form['xmlsitemap']['changecount'] = array(" but
| | found "//$form['xmlsitemap']['changecount'] =
| | array("
800 | WARNING | [x] There must be no blank line following an inline
| | comment
800 | ERROR | [x] No space found before comment text; expected "//
| | );" but found "//);"
800 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
812 | ERROR | [ ] Missing parameter type
814 | ERROR | [ ] Missing parameter type
816 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
816 | ERROR | [ ] Return type missing for @return tag in function
| | comment
855 | ERROR | [ ] Missing parameter type
857 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
857 | ERROR | [ ] Return type missing for @return tag in function
| | comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 37 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...upal_DCOH/Drupal/sites/all/modules/xmlsitemap/xmlsitemap.api.php
----------------------------------------------------------------------
FOUND 9 ERRORS AND 2 WARNINGS AFFECTING 11 LINES
----------------------------------------------------------------------
27 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
29 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
55 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: )
77 | ERROR | [ ] Missing parameter type
98 | ERROR | [ ] Missing parameter type
139 | ERROR | [x] Trailing punctuation for @see references is not
| | allowed.
153 | ERROR | [x] Trailing punctuation for @see references is not
| | allowed.
233 | WARNING | [ ] Line exceeds 80 characters; contains 125
| | characters
241 | ERROR | [ ] Type hint "array" missing for $attributes
248 | ERROR | [ ] Missing parameter type
280 | ERROR | [ ] Missing parameter type
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...al_DCOH/Drupal/sites/all/modules/xmlsitemap/xmlsitemap.drush.inc
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
167 | ERROR | If the line declaring an array spans longer than 80
| | characters, each element should be broken into its own
| | line
----------------------------------------------------------------------
FILE: ...DCOH/Drupal/sites/all/modules/xmlsitemap/xmlsitemap.generate.inc
----------------------------------------------------------------------
FOUND 23 ERRORS AND 3 WARNINGS AFFECTING 23 LINES
----------------------------------------------------------------------
17 | ERROR | [ ] Missing parameter type
19 | ERROR | [ ] Missing parameter type
73 | ERROR | [x] Array indentation error, expected 6 spaces but
| | found 8
74 | ERROR | [x] Array closing indentation error, expected 4
| | spaces but found 6
80 | ERROR | [x] Missing function doc comment
116 | ERROR | [ ] Missing parameter type
135 | ERROR | [ ] Missing parameter type
137 | ERROR | [ ] Missing parameter type
150 | WARNING | [ ] Code after THROW statement cannot be executed
156 | ERROR | [x] Missing function doc comment
157 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
172 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
244 | ERROR | [ ] Missing parameter type
257 | WARNING | [ ] Code after THROW statement cannot be executed
263 | WARNING | [x] There must be no blank line following an inline
| | comment
263 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
268 | ERROR | [ ] Missing parameter type
277 | ERROR | [x] No space found before comment text; expected "//
| | $t = get_t();" but found "//$t = get_t();"
280 | ERROR | [x] No space found before comment text; expected "//
| | 'error_message' => $t('An error has
| | occurred.')," but found "//'error_message' =>
| | $t('An error has occurred.'),"
280 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
364 | ERROR | [x] No space found before comment text; expected "//
| | drupal_set_message(t('The sitemaps were
| | regenerated.'));" but found
| | "//drupal_set_message(t('The sitemaps were
| | regenerated.'));"
395 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
471 | ERROR | [x] No space found before comment text; expected "//
| | variable_get('xmlsitemap_batch_limit', 100)" but
| | found "//variable_get('xmlsitemap_batch_limit',
| | 100)"
471 | ERROR | [x] Comments may not appear after statements
480 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
502 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...s/Drupal_DCOH/Drupal/sites/all/modules/xmlsitemap/xmlsitemap.inc
----------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------
22 | ERROR | [ ] The $text argument to l() should be enclosed within
| | t() so that it is translatable
23 | ERROR | [ ] The $text argument to l() should be enclosed within
| | t() so that it is translatable
24 | ERROR | [ ] The $text argument to l() should be enclosed within
| | t() so that it is translatable
25 | ERROR | [ ] The $text argument to l() should be enclosed within
| | t() so that it is translatable
26 | ERROR | [ ] The $text argument to l() should be enclosed within
| | t() so that it is translatable
30 | ERROR | [x] No space found before comment text; expected "//
| | http://drupalmodules.com/module/xml-sitemap" but
| | found
| | "//http://drupalmodules.com/module/xml-sitemap"
37 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../Drupal_DCOH/Drupal/sites/all/modules/xmlsitemap/xmlsitemap.info
----------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------
5 | ERROR | It's only necessary to declare files[] if they declare
| | a class or interface.
6 | ERROR | It's only necessary to declare files[] if they declare
| | a class or interface.
7 | ERROR | It's only necessary to declare files[] if they declare
| | a class or interface.
8 | ERROR | It's only necessary to declare files[] if they declare
| | a class or interface.
9 | ERROR | It's only necessary to declare files[] if they declare
| | a class or interface.
11 | ERROR | It's only necessary to declare files[] if they declare
| | a class or interface.
12 | ERROR | It's only necessary to declare files[] if they declare
| | a class or interface.
----------------------------------------------------------------------
FILE: ...upal_DCOH/Drupal/sites/all/modules/xmlsitemap/xmlsitemap.install
----------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 10 LINES
----------------------------------------------------------------------
65 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
114 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
217 | ERROR | [x] No space found before comment text; expected "//
| | 'default' => 0.5," but found "//'default' =>
| | 0.5,"
218 | ERROR | [x] No space found before comment text; expected "//
| | 'not null' => NULL," but found "//'not null' =>
| | NULL,"
289 | ERROR | [x] No space found before comment text; expected "//
| | 'queued' => array(" but found "//'queued' =>
| | array("
294 | WARNING | [ ] Line exceeds 80 characters; contains 98
| | characters
295 | ERROR | [x] No space found before comment text; expected "//
| | )," but found "//),"
295 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
467 | ERROR | [ ] Doc comment short description must be on a
| | single line, further text should be a separate
| | paragraph
543 | ERROR | [ ] Doc comment short description must be on a
| | single line, further text should be a separate
| | paragraph
557 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...rupal_DCOH/Drupal/sites/all/modules/xmlsitemap/xmlsitemap.module
----------------------------------------------------------------------
FOUND 112 ERRORS AND 1 WARNING AFFECTING 92 LINES
----------------------------------------------------------------------
4 | ERROR | [x] The second line in the file doc comment must be
| | "@file"
22 | ERROR | [x] Comments may not appear after statements
23 | ERROR | [x] Comments may not appear after statements
24 | ERROR | [x] Comments may not appear after statements
25 | ERROR | [x] Comments may not appear after statements
26 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
26 | ERROR | [x] Comments may not appear after statements
99 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
101 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
103 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
341 | ERROR | [ ] Missing parameter type
344 | ERROR | [ ] Return type missing for @return tag in function
| | comment
355 | ERROR | [ ] Missing parameter type
357 | ERROR | [ ] Missing parameter type
360 | ERROR | [ ] Return type missing for @return tag in function
| | comment
386 | ERROR | [ ] Missing parameter type
404 | ERROR | [ ] Missing parameter type
453 | ERROR | [ ] Missing parameter type
463 | ERROR | [ ] Missing parameter type
470 | ERROR | [x] Object operator not indented correctly;
| | expected 6 spaces but found 8
483 | ERROR | [ ] Missing parameter type
485 | ERROR | [ ] Missing parameter type
495 | ERROR | [ ] Missing parameter type
507 | ERROR | [x] Missing function doc comment
515 | ERROR | [ ] Missing parameter type
517 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
517 | ERROR | [ ] Return type missing for @return tag in function
| | comment
535 | ERROR | [ ] Missing parameter type
537 | ERROR | [ ] Missing parameter type
539 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
539 | ERROR | [ ] Return type missing for @return tag in function
| | comment
550 | ERROR | [ ] Missing parameter type
553 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
553 | ERROR | [ ] Return type missing for @return tag in function
| | comment
599 | ERROR | [ ] If the line declaring an array spans longer
| | than 80 characters, each element should be
| | broken into its own line
602 | ERROR | [ ] If the line declaring an array spans longer
| | than 80 characters, each element should be
| | broken into its own line
632 | ERROR | [ ] Missing parameter type
634 | ERROR | [ ] Missing parameter type
636 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
636 | ERROR | [ ] Return type missing for @return tag in function
| | comment
662 | ERROR | [ ] Missing parameter type
664 | ERROR | [ ] Missing parameter type
666 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
666 | ERROR | [ ] Return type missing for @return tag in function
| | comment
680 | ERROR | [ ] Missing parameter type
683 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
683 | ERROR | [ ] Return type missing for @return tag in function
| | comment
712 | ERROR | [ ] Missing parameter type
714 | ERROR | [ ] Missing parameter type
717 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
717 | ERROR | [ ] Return type missing for @return tag in function
| | comment
743 | ERROR | [ ] Missing parameter type
745 | ERROR | [ ] Missing parameter type
749 | ERROR | [ ] Missing parameter type
752 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
752 | ERROR | [ ] Return type missing for @return tag in function
| | comment
775 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
789 | ERROR | [x] There must be no blank lines after the function
| | comment
818 | ERROR | [x] Missing function doc comment
840 | ERROR | [x] Missing function doc comment
848 | ERROR | [ ] Missing parameter type
850 | ERROR | [ ] Missing parameter type
852 | ERROR | [ ] Missing parameter type
855 | ERROR | [ ] Return type missing for @return tag in function
| | comment
885 | ERROR | [ ] Missing parameter type
887 | ERROR | [ ] Missing parameter type
911 | ERROR | [ ] Missing parameter type
914 | ERROR | [ ] Missing parameter type
946 | ERROR | [x] No space found before comment text; expected
| | "//
| | unset($link_info[$key]['bundles'][$bundle_key]);"
| | but found
| | "//unset($link_info[$key]['bundles'][$bundle_key]);"
946 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
982 | ERROR | [x] Missing function doc comment
988 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
| | found 4
988 | ERROR | [x] No space found before comment text; expected
| | "// if
| | (!empty($bundle_info['xmlsitemap']['status']))
| | {" but found "//if
| | (!empty($bundle_info['xmlsitemap']['status']))
| | {"
988 | ERROR | [x] Inline comments must start with a capital
| | letter
988 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
995 | ERROR | [x] Missing function doc comment
1005 | ERROR | [x] No space found before comment text; expected
| | "//
| | $total->addTag('xmlsitemap_link_bundle_access');"
| | but found
| | "//$total->addTag('xmlsitemap_link_bundle_access');"
1005 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
1030 | ERROR | [x] Missing function doc comment
1034 | ERROR | [ ] If the line declaring an array spans longer
| | than 80 characters, each element should be
| | broken into its own line
1037 | ERROR | [ ] If the line declaring an array spans longer
| | than 80 characters, each element should be
| | broken into its own line
1043 | ERROR | [x] No space found before comment text; expected
| | "// xmlsitemap_get_link_info(NULL, TRUE);" but
| | found "//xmlsitemap_get_link_info(NULL, TRUE);"
1043 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
1046 | ERROR | [x] Missing function doc comment
1073 | ERROR | [x] Missing function doc comment
1092 | ERROR | [x] Missing function doc comment
1098 | ERROR | [x] No space found before comment text; expected
| | "// xmlsitemap_get_link_info(NULL, TRUE);" but
| | found "//xmlsitemap_get_link_info(NULL, TRUE);"
1098 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
1101 | ERROR | [x] Missing function doc comment
1125 | ERROR | [x] Missing function doc comment
1156 | ERROR | [ ] Missing parameter type
1158 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
1158 | ERROR | [ ] Return type missing for @return tag in function
| | comment
1206 | ERROR | [ ] Missing parameter type
1208 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
1208 | ERROR | [ ] Return type missing for @return tag in function
| | comment
1216 | WARNING | [ ] Line exceeds 80 characters; contains 84
| | characters
1216 | ERROR | [x] Comments may not appear after statements
1226 | ERROR | [ ] Missing parameter type
1238 | ERROR | [ ] Missing parameter type
1240 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
1240 | ERROR | [ ] Return type missing for @return tag in function
| | comment
1331 | ERROR | [ ] Return type missing for @return tag in function
| | comment
1332 | ERROR | [x] Return comment indentation must be 3 spaces,
| | found 2 spaces
1338 | ERROR | [x] Missing function doc comment
1356 | ERROR | [x] Missing function doc comment
1386 | ERROR | [ ] Missing short description in doc comment
1406 | ERROR | [ ] Missing parameter type
1408 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
1408 | ERROR | [ ] Return type missing for @return tag in function
| | comment
1425 | ERROR | [x] There must be no blank lines after the function
| | comment
1468 | ERROR | [x] Missing function doc comment
1539 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 55 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...al_DCOH/Drupal/sites/all/modules/xmlsitemap/xmlsitemap.pages.inc
----------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------
77 | WARNING | [ ] Line exceeds 80 characters; contains 100
| | characters
77 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
84 | ERROR | [x] No space found before comment text; expected "//
| | 'Content-length' => filesize($file)," but found
| | "//'Content-length' => filesize($file),"
118 | ERROR | [x] Expected 1 space before "*"; 0 found
118 | ERROR | [x] Expected 1 space after "*"; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../Drupal_DCOH/Drupal/sites/all/modules/xmlsitemap/xmlsitemap.test
----------------------------------------------------------------------
FOUND 116 ERRORS AND 9 WARNINGS AFFECTING 98 LINES
----------------------------------------------------------------------
14 | ERROR | [ ] Class property $admin_user should use lowerCamel
| | naming without underscores
16 | ERROR | [x] Missing function doc comment
16 | ERROR | [x] Visibility must be declared on method "setUp"
21 | ERROR | [x] Missing function doc comment
21 | ERROR | [x] Visibility must be declared on method "tearDown"
31 | ERROR | [ ] Missing parameter type
34 | ERROR | [ ] Missing parameter type
36 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
36 | ERROR | [ ] Return type missing for @return tag in function
| | comment
59 | ERROR | [ ] Missing parameter type
61 | ERROR | [ ] Missing parameter type
64 | ERROR | [ ] Missing parameter type
67 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
67 | ERROR | [ ] Return type missing for @return tag in function
| | comment
88 | ERROR | [x] Missing function doc comment
100 | ERROR | [x] Missing function doc comment
112 | ERROR | [x] Missing function doc comment
117 | ERROR | [x] Missing function doc comment
122 | ERROR | [x] Missing function doc comment
132 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
136 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
141 | ERROR | [x] Missing function doc comment
151 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
155 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
160 | ERROR | [x] Missing function doc comment
168 | ERROR | [x] Missing function doc comment
176 | ERROR | [x] Missing function doc comment
194 | ERROR | [x] Missing function doc comment
204 | ERROR | [x] Missing function doc comment
204 | ERROR | [ ] Protected method name
| | "XMLSitemapTestHelper::assertXMLSitemapProblems"
| | is not in lowerCamel format
212 | ERROR | [x] Missing function doc comment
212 | ERROR | [ ] Protected method name
| | "XMLSitemapTestHelper::assertNoXMLSitemapProblems"
| | is not in lowerCamel format
231 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
248 | ERROR | [x] Missing function doc comment
252 | ERROR | [x] Missing function doc comment
265 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
283 | ERROR | [ ] Missing parameter type
285 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
285 | ERROR | [ ] Return type missing for @return tag in function
| | comment
311 | ERROR | [ ] Missing parameter type
313 | ERROR | [ ] Missing parameter type
315 | ERROR | [x] Separate the @param and @see sections by a blank
| | line.
324 | ERROR | [x] Expected 1 blank line after function; 0 found
325 | ERROR | [x] The closing brace for the class must have an
| | empty line before it
327 | ERROR | [x] Missing class doc comment
328 | ERROR | [x] Missing function doc comment
328 | ERROR | [x] Expected 1 blank line before function; 0 found
336 | ERROR | [x] Missing function doc comment
336 | ERROR | [x] Visibility must be declared on method
| | "testAssertFlag"
350 | ERROR | [x] Visibility must be declared on method
| | "testGetChangefreq"
384 | ERROR | [x] Visibility must be declared on method
| | "testGetChunkCount"
415 | ERROR | [x] No space found before comment text; expected "//
| | function testGetChunkFile() {" but found
| | "//function testGetChunkFile() {"
415 | ERROR | [x] Inline comments must start with a capital letter
416 | ERROR | [x] No space found before comment text; expected "//
| | }" but found "//}"
418 | ERROR | [x] No space found before comment text; expected "//
| | function testGetChunkSize() {" but found
| | "//function testGetChunkSize() {"
419 | ERROR | [x] No space found before comment text; expected "//
| | }" but found "//}"
421 | ERROR | [x] No space found before comment text; expected "//
| | function testGetLinkCount() {" but found
| | "//function testGetLinkCount() {"
422 | WARNING | [x] There must be no blank line following an inline
| | comment
422 | ERROR | [x] No space found before comment text; expected "//
| | }" but found "//}"
422 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
427 | ERROR | [x] Visibility must be declared on method
| | "testCalculateChangefreq"
449 | ERROR | [x] Visibility must be declared on method
| | "testRecalculateChangefreq"
451 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
469 | ERROR | [x] Visibility must be declared on method
| | "testSwitchUser"
512 | ERROR | [x] No space found before comment text; expected "//
| | function testLoadLink() {" but found "//function
| | testLoadLink() {"
512 | ERROR | [x] Inline comments must start with a capital letter
513 | WARNING | [x] There must be no blank line following an inline
| | comment
513 | ERROR | [x] No space found before comment text; expected "//
| | }" but found "//}"
513 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
518 | ERROR | [x] Visibility must be declared on method
| | "testSaveLink"
519 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
567 | ERROR | [x] Visibility must be declared on method
| | "testLinkDelete"
592 | ERROR | [x] Visibility must be declared on method
| | "testUpdateLinks"
599 | ERROR | [x] Inline comments must start with a capital letter
602 | WARNING | [x] There must be no blank line following an inline
| | comment
602 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
604 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
607 | ERROR | [x] Inline comments must start with a capital letter
610 | WARNING | [x] There must be no blank line following an inline
| | comment
610 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
612 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
615 | ERROR | [x] Inline comments must start with a capital letter
618 | WARNING | [x] There must be no blank line following an inline
| | comment
618 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
623 | ERROR | [x] Inline comments must start with a capital letter
626 | WARNING | [x] There must be no blank line following an inline
| | comment
626 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
628 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
631 | ERROR | [x] Inline comments must start with a capital letter
634 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
640 | ERROR | [x] Visibility must be declared on method
| | "testDuplicatePaths"
651 | ERROR | [x] Visibility must be declared on method
| | "testMinimumLifetime"
675 | ERROR | [x] Expected 1 blank line after function; 0 found
676 | ERROR | [x] The closing brace for the class must have an
| | empty line before it
678 | ERROR | [x] Missing class doc comment
679 | ERROR | [x] Missing function doc comment
679 | ERROR | [x] Expected 1 blank line before function; 0 found
687 | ERROR | [x] Missing function doc comment
687 | ERROR | [x] Visibility must be declared on method "setUp"
690 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
697 | ERROR | [x] Visibility must be declared on method
| | "testSitemapCaching"
713 | ERROR | [ ] Method name
| | "XMLSitemapFunctionalTest::testBaseURL" is not
| | in lowerCamel format
713 | ERROR | [x] Visibility must be declared on method
| | "testBaseURL"
736 | WARNING | [ ] Line exceeds 80 characters; contains 81
| | characters
738 | ERROR | [x] Visibility must be declared on method
| | "testStatusReport"
741 | ERROR | [x] No space found before comment text; expected "//
| | variable_set('xmlsitemap_generated_last',
| | REQUEST_TIME);" but found
| | "//variable_set('xmlsitemap_generated_last',
| | REQUEST_TIME);"
742 | ERROR | [x] No space found before comment text; expected "//
| | variable_set('xmlsitemap_rebuild_needed',
| | TRUE);" but found
| | "//variable_set('xmlsitemap_rebuild_needed',
| | TRUE);"
743 | WARNING | [ ] Line exceeds 80 characters; contains 116
| | characters
743 | ERROR | [x] No space found before comment text; expected "//
| | $this->assertXMLSitemapProblems(t('The XML
| | sitemap data is out of sync and needs to be
| | completely rebuilt.'));" but found
| | "//$this->assertXMLSitemapProblems(t('The XML
| | sitemap data is out of sync and needs to be
| | completely rebuilt.'));"
744 | ERROR | [x] No space found before comment text; expected "//
| | $this->clickLink(t('completely rebuilt'));" but
| | found "//$this->clickLink(t('completely
| | rebuilt'));"
745 | ERROR | [x] No space found before comment text; expected "//
| | $this->assertResponse(200);" but found
| | "//$this->assertResponse(200);"
746 | ERROR | [x] No space found before comment text; expected "//
| | variable_set('xmlsitemap_rebuild_needed',
| | FALSE);" but found
| | "//variable_set('xmlsitemap_rebuild_needed',
| | FALSE);"
747 | WARNING | [x] There must be no blank line following an inline
| | comment
747 | ERROR | [x] No space found before comment text; expected "//
| | $this->assertNoXMLSitemapProblems();" but found
| | "//$this->assertNoXMLSitemapProblems();"
759 | ERROR | [x] Expected 1 blank line after function; 0 found
760 | ERROR | [x] The closing brace for the class must have an
| | empty line before it
762 | ERROR | [x] Missing class doc comment
763 | ERROR | [x] Missing function doc comment
763 | ERROR | [x] Expected 1 blank line before function; 0 found
772 | ERROR | [x] Missing function doc comment
772 | ERROR | [x] Visibility must be declared on method "setUp"
777 | ERROR | [x] Missing function doc comment
777 | ERROR | [x] Visibility must be declared on method
| | "testRobotsTxt"
782 | ERROR | [x] Expected 1 blank line after function; 0 found
783 | ERROR | [x] The closing brace for the class must have an
| | empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 96 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...OH/Drupal/sites/all/modules/xmlsitemap/xmlsitemap.xmlsitemap.inc
----------------------------------------------------------------------
FOUND 35 ERRORS AND 1 WARNING AFFECTING 29 LINES
----------------------------------------------------------------------
8 | ERROR | [x] Missing class doc comment
10 | ERROR | [x] Missing class doc comment
20 | ERROR | [ ] Class property $sitemap_page should use
| | lowerCamel naming without underscores
26 | ERROR | [ ] Missing parameter type
28 | ERROR | [ ] Missing parameter type
31 | ERROR | [x] Visibility must be declared on method
| | "__construct"
38 | ERROR | [x] Missing function doc comment
46 | ERROR | [x] Missing function doc comment
59 | ERROR | [x] Missing function doc comment
76 | ERROR | [ ] Public method name "XMLSitemapWriter::writeXSL"
| | is not in lowerCamel format
96 | ERROR | [x] Missing function doc comment
96 | ERROR | [ ] Public method name
| | "XMLSitemapWriter::generateXML" is not in
| | lowerCamel format
100 | ERROR | [x] Missing function doc comment
114 | ERROR | [ ] Missing parameter type
116 | ERROR | [ ] Missing parameter type
155 | ERROR | [x] Missing function doc comment
155 | ERROR | [ ] Public method name "XMLSitemapWriter::getURI" is
| | not in lowerCamel format
159 | ERROR | [x] Missing function doc comment
163 | ERROR | [x] Missing function doc comment
170 | ERROR | [x] No space found before comment text; expected "//
| | if (xmlsitemap_var('gz')) {" but found "//if
| | (xmlsitemap_var('gz')) {"
170 | ERROR | [x] Inline comments must start with a capital letter
173 | WARNING | [x] There must be no blank line following an inline
| | comment
173 | ERROR | [x] No space found before comment text; expected "//
| | }" but found "//}"
173 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
176 | ERROR | [x] Expected 1 blank line after function; 0 found
177 | ERROR | [x] The closing brace for the class must have an
| | empty line before it
179 | ERROR | [x] Missing class doc comment
180 | ERROR | [x] You must use "/**" style comments for a member
| | variable comment
182 | ERROR | [x] Missing function doc comment
182 | ERROR | [x] Visibility must be declared on method
| | "__construct"
186 | ERROR | [x] Missing function doc comment
198 | ERROR | [x] Missing function doc comment
198 | ERROR | [ ] Public method name
| | "XMLSitemapIndexWriter::generateXML" is not in
| | lowerCamel format
209 | ERROR | [x] Expected 1 blank line after function; 0 found
210 | ERROR | [x] The closing brace for the class must have an
| | empty line before it
288 | ERROR | [ ] Missing parameter type
----------------------------------------------------------------------
PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...es/all/modules/xmlsitemap/xmlsitemap_node/xmlsitemap_node.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
131 | ERROR | Missing short description in doc comment
----------------------------------------------------------------------
FILE: ..._DCOH/Drupal/sites/all/modules/xmlsitemap/xsl/xmlsitemap.xsl.css
----------------------------------------------------------------------
FOUND 13 ERRORS AFFECTING 13 LINES
----------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
3 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #fff but found #FFF
11 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #cdcdcd but found #CDCDCD
12 | ERROR | [x] Expected 1 space after colon in style definition; 0
| | found
17 | ERROR | [x] Multiple selectors should each be on a single line
18 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #e6eeee but found #E6EEEE
19 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #fff but found #FFF
27 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #3d3d3d but found #3D3D3D
29 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #fff but found #FFF
33 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #efefef but found #EFEFEF
41 | ERROR | [x] Multiple selectors should each be on a single line
42 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #5050d3 but found #5050D3
43 | ERROR | [x] CSS colours must be defined in lowercase; expected
| | #fff but found #FFF
----------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Proposed resolution
Fixed items following Drupal Coding Standards and https://www.drupal.org/docs/7/site-building-best-practices/best-practices
Remaining tasks
None
User interface changes
None
API changes
None
Data model changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | fix_drupal_sniffer_and-2906673-2.patch | 72.49 KB | renatog |
Comments
Comment #2
renatogPatch with the fixes:
xmlsitemap.admin.inc
xmlsitemap.api.php
xmlsitemap.generate.inc
xmlsitemap.inc
xmlsitemap.install
xmlsitemap.module
xmlsitemap.pages.inc
xmlsitemap.test
xmlsitemap.xmlsitemap.inc
xmlsitemap_node/xmlsitemap_node.module
xsl/xmlsitemap.xsl.css
Follo in the attachment.
Regards.
Comment #4
renatogComment #5
renatogFixed.
Committed to the dev branch.
Thank you very much.
Good Work and Good Week.
Regards.