Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Please, fix the follow lines:
FILE: ...ules/xmlsitemap/xmlsitemap_engines/tests/xmlsitemap_engines.test
----------------------------------------------------------------------
FOUND 24 ERRORS AFFECTING 16 LINES
----------------------------------------------------------------------
8 | ERROR | [x] Missing class doc comment
9 | ERROR | [ ] Class property $submit_url should use lowerCamel
| | naming without underscores
11 | ERROR | [x] Missing function doc comment
19 | ERROR | [x] Missing function doc comment
19 | ERROR | [x] Visibility must be declared on method "setUp"
35 | ERROR | [x] Missing function doc comment
35 | ERROR | [x] Visibility must be declared on method
| | "submitEngines"
43 | ERROR | [x] Missing function doc comment
43 | ERROR | [ ] Method name
| | "XMLSitemapEnginesFunctionalTest::testPrepareURL"
| | is not in lowerCamel format
43 | ERROR | [x] Visibility must be declared on method
| | "testPrepareURL"
50 | ERROR | [x] Missing function doc comment
50 | ERROR | [x] Visibility must be declared on method
| | "testSubmitSitemaps"
66 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken into
| | its own line
67 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken into
| | its own line
70 | ERROR | [x] Missing function doc comment
70 | ERROR | [x] Visibility must be declared on method "testPing"
80 | ERROR | [x] Missing function doc comment
80 | ERROR | [ ] Method name
| | "XMLSitemapEnginesFunctionalTest::testCustomURL"
| | is not in lowerCamel format
80 | ERROR | [x] Visibility must be declared on method
| | "testCustomURL"
92 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken into
| | its own line
102 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken into
| | its own line
103 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken into
| | its own line
104 | ERROR | [x] Expected 1 blank line after function; 0 found
105 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
----------------------------------------------------------------------
FILE: ...xmlsitemap/xmlsitemap_engines/tests/xmlsitemap_engines_test.info
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
5 | ERROR | It's only necessary to declare files[] if they declare a
| | class or interface.
----------------------------------------------------------------------
FILE: ...lsitemap/xmlsitemap_engines/tests/xmlsitemap_engines_test.module
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
33 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------
FILE: ...dules/xmlsitemap/xmlsitemap_engines/xmlsitemap_engines.admin.inc
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
29 | ERROR | If the line declaring an array spans longer than 80
| | characters, each element should be broken into its own
| | line
40 | ERROR | If the line declaring an array spans longer than 80
| | characters, each element should be broken into its own
| | line
----------------------------------------------------------------------
FILE: ...modules/xmlsitemap/xmlsitemap_engines/xmlsitemap_engines.api.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
19 | WARNING | [x] A comma should follow the last multiline array
| | item. Found:
| | 'http://example.com/ping?sitemap=[sitemap]'
----------------------------------------------------------------------
FILE: ...ll/modules/xmlsitemap/xmlsitemap_engines/xmlsitemap_engines.info
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
6 | ERROR | It's only necessary to declare files[] if they declare a
| | class or interface.
7 | ERROR | It's only necessary to declare files[] if they declare a
| | class or interface.
8 | ERROR | It's only necessary to declare files[] if they declare a
| | class or interface.
----------------------------------------------------------------------
FILE: .../modules/xmlsitemap/xmlsitemap_engines/xmlsitemap_engines.module
----------------------------------------------------------------------
FOUND 17 ERRORS AND 3 WARNINGS AFFECTING 14 LINES
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
44 | ERROR | [x] No space found before comment text; expected "//
| | $items['admin/config/search/xmlsitemap/engines/submit']
| | = array(" but found
| | "//$items['admin/config/search/xmlsitemap/engines/submit']
| | = array("
48 | WARNING | [x] There must be no blank line following an inline
| | comment
48 | ERROR | [x] No space found before comment text; expected "//
| | );" but found "//);"
48 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
62 | ERROR | [x] Missing function doc comment
76 | ERROR | [x] Missing function doc comment
82 | WARNING | [ ] Line exceeds 80 characters; contains 112
| | characters
82 | ERROR | [x] No space found before comment text; expected "//
| | if ($_GET['q'] ==
| | 'admin/config/search/xmlsitemap/engines/submit'
| | && user_access('administer xmlsitemap')) {" but
| | found "//if ($_GET['q'] ==
| | 'admin/config/search/xmlsitemap/engines/submit'
| | && user_access('administer xmlsitemap')) {"
84 | WARNING | [x] There must be no blank line following an inline
| | comment
84 | ERROR | [x] No space found before comment text; expected "//
| | }" but found "//}"
84 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
106 | ERROR | [ ] Missing parameter type
137 | ERROR | [ ] Missing parameter type
139 | ERROR | [ ] Missing parameter type
154 | ERROR | [ ] Missing parameter type
156 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
156 | ERROR | [ ] Return type missing for @return tag in function
| | comment
166 | ERROR | [ ] Missing parameter type
169 | ERROR | [ ] Missing parameter type
----------------------------------------------------------------------
Proposed resolution
Fixed items following Drupal Coding Standards and https://www.drupal.org/docs/7/site-building-best-practices/best-practices
Remaining tasks
None
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#2 | resolve_items_of_xml-2906627-2.patch | 14.62 KB | renatog |
Comments
Comment #2
renatogThe patch with the fix it's in attachment.
Regards.
Comment #4
renatogFixed.
Committed to the dev branch.
Regards.