Problem/Motivation

Items to be fixed:

FILE: ...ites/all/modules/xmlsitemap/xmlsitemap_i18n/xmlsitemap_i18n.info
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 7 | ERROR | It's only necessary to declare files[] if they declare a
   |       | class or interface.
----------------------------------------------------------------------


FILE: ...es/all/modules/xmlsitemap/xmlsitemap_i18n/xmlsitemap_i18n.module
----------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
----------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
  90 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
  92 | WARNING | [ ] Line exceeds 80 characters; contains 97
     |         |     characters
  94 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
  98 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 111 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
----------------------------------------------------------------------



FILE: ...ites/all/modules/xmlsitemap/xmlsitemap_i18n/xmlsitemap_i18n.test
----------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 15 LINES
----------------------------------------------------------------------
  12 | ERROR | [ ] Class property $admin_user should use lowerCamel
     |       |     naming without underscores
  17 | ERROR | [x] Visibility must be declared on method "setUp"
  39 | ERROR | [x] Expected 1 blank line after function; 0 found
  40 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
  42 | ERROR | [x] Missing class doc comment
  43 | ERROR | [x] Missing function doc comment
  43 | ERROR | [x] Expected 1 blank line before function; 0 found
  52 | ERROR | [x] Missing function doc comment
  52 | ERROR | [x] Visibility must be declared on method
     |       |     "testLanguageSelection"
 106 | ERROR | [x] Expected 1 blank line after function; 0 found
 107 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
 109 | ERROR | [x] Missing class doc comment
 110 | ERROR | [x] Missing function doc comment
 110 | ERROR | [x] Expected 1 blank line before function; 0 found
 119 | ERROR | [x] Missing function doc comment
 119 | ERROR | [x] Visibility must be declared on method "setUp"
 128 | ERROR | [x] Missing function doc comment
 128 | ERROR | [x] Visibility must be declared on method
     |       |     "testNodeLanguageData"
 138 | ERROR | [x] Expected 1 blank line after function; 0 found
 139 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
----------------------------------------------------------------------


Proposed resolution

Fixed items following Drupal Coding Standards and https://www.drupal.org/docs/7/site-building-best-practices/best-practices

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 fix_drupal_coding-2906618-2.patch5.25 KBrenatog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RenatoG created an issue. See original summary.

renatog’s picture

Patch with the fix it's in the attachment.

Regards.

  • RenatoG committed 63985a3 on 7.x-2.x
    Issue #2906618 by RenatoG: Fix Drupal Coding Standards for XML sitemap...
renatog’s picture

Status: Active » Fixed

Fixed.

Committed to the dev branch.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.