In a particular use case where users get charged for SMS they send, I don't want users to be charged for verification messages though. While it is possible to work through some hoops in MESSAGE_PRE_PROCESS to determine if an SMS is a verification message, it would be much simpler if the SmsPhoneNumberVerification service were to flag the 'is_verification_message' option to TRUE for messages that are number verifications.

CommentFileSizeAuthor
#2 sms-2906087-2.patch1.5 KBalmaudoh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

almaudoh created an issue. See original summary.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Issue summary: View changes
FileSize
sms-2906087-2.patch1.5 KB
almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Active » Needs review
dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Perhaps in the future we should have the ability to class a message. Similar to how emails in Drupal have an ID.

For now it looks consistent with what we have done in the past.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented

Perhaps in the future we should have the ability to class a message. Similar to how emails in Drupal have an ID.

That makes a lot of sense. As I was making this patch, I was also wondering how this could be made extensible.

  • almaudoh committed 54a1d92 on 8.x-1.x 
    Issue #2906087 by almaudoh: Marker to know when an SMS message is a...
almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Reviewed & tested by the community » Fixed

Committed / pushed to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.