Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Motivation
- Get rid of an outdated Context class in a connector code base.
- Get rid of an
org id
andapi key
provider settings.
Possible solution
This patch removes an old SmartlingContextApi
class and provides integration with the new class from api sdk. This patch doesn't contain updated api-sdk-php
and vendor
folders.
All tests are passed.
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff-5-6.txt | 1.27 KB | Loparev |
#6 | tmgmt_smartling-context-2905671-6.patch | 225.37 KB | Loparev |
#5 | interdiff-4-5.txt | 650 bytes | Loparev |
#5 | tmgmt_smartling-context-2905671-5.patch | 225.3 KB | Loparev |
#4 | interdiff-3-4.txt | 4.92 KB | Loparev |
Comments
Comment #2
Loparev CreditAttribution: Loparev commentedComment #3
Loparev CreditAttribution: Loparev commentedtmgmt_smartling-context.patch
- new context api integration patchtmgmt_smartling-api-sdk-php-update.patch
- updated sdktmgmt_smartling-context-2905671-3.patch
- full patchComment #4
Loparev CreditAttribution: Loparev commentedUpdated sdk (fixed issue with user agent)
Comment #5
Loparev CreditAttribution: Loparev commentedEdited file name generation
Comment #6
Loparev CreditAttribution: Loparev commentedImproved logging
Comment #8
Loparev CreditAttribution: Loparev commented