Hello.

I think one string can a little bit confuse site builders.

At this place http://take.ms/Jiyb1 the text not clear than "On label" in quotes.

I am proposing to rewrite to "Use field label instead of the "On" label as the label." or something similar.

What is the community thinking about it?

CommentFileSizeAuthor
#4 label_change.png98.54 KBvenkatesh rajan.j
#2 drupal-rename_description_for_boolean_field-2904084-2.patch1.8 KBruslan piskarov

Comments

Ruslan P created an issue. See original summary.

ruslan piskarov’s picture

ruslan piskarov
he/him
Primary language Ukrainian
Location Kyiv, Ukraine
commented
Status: Active » Needs review
StatusFileSize
new drupal-rename_description_for_boolean_field-2904084-2.patch1.8 KB

Providing the patch for it.

sutharsan’s picture

sutharsan commented
Issue tags: +Vienna2017, +Novice
venkatesh rajan.j’s picture

venkatesh rajan.j commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new label_change.png98.54 KB

Patch worked fine. Attached screenshots

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 8.4.x-dev » 8.5.x-dev
Issue tags: +Needs usability review

Checking in with the UX team about this change.

Also, string changes can't go into 8.4

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: drupal-rename_description_for_boolean_field-2904084-2.patch, failed testing. View results

ruslan piskarov’s picture

ruslan piskarov
he/him
Primary language Ukrainian
Location Kyiv, Ukraine
commented
Status: Needs work » Reviewed & tested by the community

Reverting back the status of the issue because tests were broken not by this patch.

venkatesh rajan.j’s picture

venkatesh rajan.j commented

@Ruslan,

Exactly, more number of issues are getting this kind of errors nowadays. Not sure why this is happening.

catch’s picture

catch
he/him
Primary language English
commented
Title: An Entangling title for "Boolean" field in "Manage form display" » Confusing title for "Boolean" field in "Manage form display"
yoroy’s picture

yoroy commented
Issue tags: -Needs usability review +Usability

This is fine :)

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 9c1f8ad and pushed to 8.5.x. Thanks!

  • catch committed 62cf4b5 on 8.5.x 
    Issue #2904084 by Ruslan P, Venkatesh Rajan.J: Confusing title for "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.