#2891247: Do a sanity-check on the Suggestion class will refactor the Suggestion class which is needed when creating autocomplete suggestions.
To keep disruption to a minimum, I propose changing the code to something that will work with both the old and the new version, as a first step.

CommentFileSizeAuthor
#2 2903833--2--adapt_to_autocomplete_changes.patch6.68 KBdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey for DBC commented
Status: Active » Needs review
FileSize
2903833--2--adapt_to_autocomplete_changes.patch6.68 KB

This should do it.

mkalkbrenner credited mkalkbrenner.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at bio.logis Genetic Information Management GmbH commented
Status: Needs review » Fixed

Thanks, committed.
It would be good if #2891247: Do a sanity-check on the Suggestion class gets committed soon to turn our tests back green:

1) Drupal\Tests\search_api_solr\Kernel\SearchApiSolrTest::testAutocomplete

Error: Call to undefined method Drupal\search_api_autocomplete\Suggestion::getResultsCount()

/home/travis/build/mkalkbrenner/drupal/modules/contrib/search_api_solr/tests/src/Kernel/SearchApiSolrTest.php:834

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.