[D8] Easy Install

You need to fix the code style issues.

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojecteasy_installgit

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @karthikeyan-manivasagam
I checked your code with code sniffer and got only few notice. Please check them.

FILE: /PurgeConfigurationsConfirmForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 158 | ERROR | [x] Expected 1 space after IF keyword; 0 found
 169 | ERROR | [x] Expected 1 space after IF keyword; 0 found
--------------------------------------------------------------------------

FILE: /easy_install.module
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 38 | ERROR | [x] Expected 1 space after IF keyword; 0 found
 49 | ERROR | [x] Expected 1 space after IF keyword; 0 found
----------------------------------------------------------------------

Very useful module. Great job.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Still some CS issues left. Please don't just re-set the status to "Needs review", if you didn't fix them.

Review of the 8.x-10.x branch (commit 3695698):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: ./src/Form/PurgeConfigurationsConfirmForm.php
  --------------------------------------------------------------------------
  FOUND 11 ERRORS AFFECTING 10 LINES
  --------------------------------------------------------------------------
   142 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
   159 | ERROR | [x] Expected 1 space after IF keyword; 0 found
   173 | ERROR | [x] Expected 1 space after IF keyword; 0 found
   191 | ERROR | [x] Expected 1 space after IF keyword; 0 found
   192 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
   194 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5
   194 | ERROR | [x] Expected 1 space after IF keyword; 0 found
   201 | ERROR | [x] Closing brace indented incorrectly; expected 5 spaces,
       |       |     found 4
   202 | ERROR | [x] Expected 1 space after IF keyword; 0 found
   203 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
   234 | ERROR | [x] Whitespace found at end of line
  --------------------------------------------------------------------------
  PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  --------------------------------------------------------------------------
  
  
  FILE: ./easy_install.module
  --------------------------------------------------------------------------
  FOUND 7 ERRORS AFFECTING 7 LINES
  --------------------------------------------------------------------------
   39 | ERROR | [x] Expected 1 space after IF keyword; 0 found
   53 | ERROR | [x] Expected 1 space after IF keyword; 0 found
   71 | ERROR | [x] Expected 1 space after IF keyword; 0 found
   72 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
   74 | ERROR | [x] Expected 1 space after IF keyword; 0 found
   87 | ERROR | [x] Expected 1 space after IF keyword; 0 found
   88 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
  --------------------------------------------------------------------------
  PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  --------------------------------------------------------------------------
  
  Time: 639ms; Memory: 6Mb
  

• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: ./src/Form/PurgeConfigurationsConfirmForm.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   239 | WARNING | Unused variable $msg.
  --------------------------------------------------------------------------
  
  Time: 306ms; Memory: 6Mb
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

The coding standard issues are gone indeed. But also your README.txt file.

When restoring it, please make sure it follows the structure of the README template.

Review of the 8.x-10.x branch (commit e3f6afd):

• README.md or README.txt is missing, see the guidelines for in-project documentation.
• No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

Review of the 8.x-10.x branch (commit 952de88):

Please check your README.md. It has some nasty tabs inside, while also using space indentation.
You may IMHO just omit the "REQUIREMENTS" section, if there are none. The CONFIGURATION section has a typo: "Whenenabled".

Without having used your module yet (nothing to re-/uninstall ;)), some last things to do referring your source code documentation/translatability.

Review of the 8.x-10.x branch (commit 42ef516):

• The easy_install.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
• Improve easy_install_form_submit() doc block documentation (add a brief summary what it does and also document the parameters) and consider adding some inline comments to that function in order to let people know what you are doing/comparing.
• The messages of your submit callback will never be translated. Whatever you tried doing there, you should refactor it.
• Maybe also fix the spelling in line 29 of your easy_install.module file.

The module looks good. All the issues mentioned above is applied with the module. Moving the same to RTBC. Thanks

I would really like any git administrator to review this project and if possible give access to opt into security advisory coverage as this project is very useful for developers.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.