If the script is loading and undefined `CKEDITOR`, the test will throw an error immediately and stop the script rather than wait for conditions.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

droplet created an issue. See original summary.

droplet’s picture

Title: Check CKEDITOR exists prevent script throws error immedately » Check CKEDITOR exists to prevent script throws error immediately
droplet’s picture

FileSize
869 bytes

Remove extra spaces

The last submitted patch, bigpipe_test.patch, failed testing. View results

Wim Leers’s picture

Status: Needs review » Needs work

This needs a failing test to prove this change is necessary.

I do t understand why this is necessary, because the tests are clearly already passing.

Wim Leers’s picture

Category: Bug report » Task
Priority: Normal » Minor

Also, this is test hardening at best, so task, not bug.

Wim Leers’s picture

Title: Check CKEDITOR exists to prevent script throws error immediately » BigPipe test hardening: check that CKEDITOR exists to prevent script throws error immediately

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.