Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After upgrading from 8.x.5.0.0-beta15 to 8.x.5.0.0-beta16 our email templates broke down. The [webform_submission] placeholder was replaced by empty values, instead of the submission content.
This bug was introduced after commit 224e93c "Issue #2898158 by jrockowitz, amairesse:
Comment | File | Size | Author |
---|---|---|---|
#9 | Screen Shot 2017-09-06 at 11.17.07 AM.png | 101 KB | jrockowitz |
#9 | Screen Shot 2017-09-06 at 11.17.19 AM.png | 111.34 KB | jrockowitz |
#9 | webform.webform.issue_2903612.yml | 2.93 KB | jrockowitz |
#6 | webform.webform.issue_2903612.yml | 3.4 KB | jrockowitz |
#5 | webform-fix_wrong_submission_values-2903612-5.patch | 863 bytes | jeroen.b |
|
Comments
Comment #2
jrockowitz CreditAttribution: jrockowitz commentedThanks for the patch.
Changing this ticket's status to 'Needs review' to trigger the automated tested.
I think the attached patch might have issues dealing with nested elements but I am not able to verify this right now. (I am on vacation)
Comment #3
jeroen.b CreditAttribution: jeroen.b at .VDMi/ commentedI think tests only work when patch is in a comment.
Comment #5
jeroen.b CreditAttribution: jeroen.b at .VDMi/ commentedI think the format of the patch was wrong. Here's an updated version.
Comment #6
jrockowitz CreditAttribution: jrockowitz commentedI can't replicate the issue using the attached webform. Can someone please upload an example of a broken webform that uses the [webform_submission:values] token.
I suspect the issue is related to nested elements and/or multistep forms.
This is a major issue so we will definitely need to include some test coverage to prevent any additional regressions.
Comment #7
jrockowitz CreditAttribution: jrockowitz commentedComment #8
nachosalvador CreditAttribution: nachosalvador commentedI experienced a similar behaviour after upgrading from 8.x.5.0.0-beta15 to 8.x.5.0.0-beta16.
In my case I use a [webform_submission:values] token in the confirmation message. This value is calculated/setted in the submitForm() and before beta16 works correctly, right now this token value comes empty.
At the moment I solved it moving to version 8.x-5.x-dev :)
Comment #9
jrockowitz CreditAttribution: jrockowitz commentedI can't replicate the [webform_submission:values] issue in the confirmation. Please test the attached webform.
Comment #10
jrockowitz CreditAttribution: jrockowitz commented